Page MenuHomePhabricator

[sanitizer_common] Fuchsia now supports .preinit_array
ClosedPublic

Authored by phosek on Sep 16 2018, 2:15 PM.

Details

Summary

Support for .preinit_array has been implemented in Fuchsia's libc,
add Fuchsia to the list of platforms that support this feature.

Diff Detail

Event Timeline

phosek created this revision.Sep 16 2018, 2:15 PM
mcgrathr accepted this revision.Sep 16 2018, 2:36 PM

lgtm. Note that most sanitizer runtime ports for Fuchsia will be DSO-only, but I think the #ifndef PIC condition will cover that if/when those cases come up.
For always-static runtimes that can't be statically linked into DSOs (i.e. runtime library is not included in -shared links) this should now be right for Fuchsia.
IIRC profile is always-static but meant to be statically linked separately into each DSO, but presumably that means it's built with PIC defined too.

This revision is now accepted and ready to land.Sep 16 2018, 2:36 PM
This revision was automatically updated to reflect the committed changes.