This is an archive of the discontinued LLVM Phabricator instance.

Differential D52155

[sanitizer_common] Fuchsia now supports .preinit_array
ClosedPublic

Authored by phosek on Sep 16 2018, 2:15 PM.

Details

Reviewers
vitalybuka
morehouse
mcgrathr
Commits
rG040ab65c533b: [sanitizer_common] Fuchsia now supports .preinit_array
rCRT342357: [sanitizer_common] Fuchsia now supports .preinit_array
rL342357: [sanitizer_common] Fuchsia now supports .preinit_array
Summary

Support for .preinit_array has been implemented in Fuchsia's libc,
add Fuchsia to the list of platforms that support this feature.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Sep 16 2018, 2:15 PM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek, srhines. · View Herald TranscriptSep 16 2018, 2:15 PM
mcgrathr accepted this revision.Sep 16 2018, 2:36 PM

lgtm. Note that most sanitizer runtime ports for Fuchsia will be DSO-only, but I think the #ifndef PIC condition will cover that if/when those cases come up.
For always-static runtimes that can't be statically linked into DSOs (i.e. runtime library is not included in -shared links) this should now be right for Fuchsia.
IIRC profile is always-static but meant to be statically linked separately into each DSO, but presumably that means it's built with PIC defined too.

This revision is now accepted and ready to land.Sep 16 2018, 2:36 PM
Closed by commit rL342357: [sanitizer_common] Fuchsia now supports .preinit_array (authored by phosek). · Explain WhySep 16 2018, 10:23 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptSep 16 2018, 10:23 PM

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
4 lines

Diff 165711

compiler-rt/trunk/lib/sanitizer_common/sanitizer_internal_defs.h

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines
// functions very early in the process startup (unless PIC macro is defined). // functions very early in the process startup (unless PIC macro is defined).
// //
// On FreeBSD, .preinit_array functions are called with rtld_bind_lock writer // On FreeBSD, .preinit_array functions are called with rtld_bind_lock writer
// lock held. It will lead to dead lock if unresolved PLT functions (which helds // lock held. It will lead to dead lock if unresolved PLT functions (which helds
// rtld_bind_lock reader lock) are called inside .preinit_array functions. // rtld_bind_lock reader lock) are called inside .preinit_array functions.
// //
// FIXME: do we have anything like this on Mac? // FIXME: do we have anything like this on Mac?
#ifndef SANITIZER_CAN_USE_PREINIT_ARRAY #ifndef SANITIZER_CAN_USE_PREINIT_ARRAY
#if ((SANITIZER_LINUX && !SANITIZER_ANDROID) || SANITIZER_OPENBSD) && \ #if ((SANITIZER_LINUX && !SANITIZER_ANDROID) || SANITIZER_OPENBSD || \
!defined(PIC) SANITIZER_FUCHSIA) && !defined(PIC)
#define SANITIZER_CAN_USE_PREINIT_ARRAY 1 #define SANITIZER_CAN_USE_PREINIT_ARRAY 1
// Before Solaris 11.4, .preinit_array is fully supported only with GNU ld. // Before Solaris 11.4, .preinit_array is fully supported only with GNU ld.
// FIXME: Check for those conditions. // FIXME: Check for those conditions.
#elif SANITIZER_SOLARIS && !defined(PIC) #elif SANITIZER_SOLARIS && !defined(PIC)
# define SANITIZER_CAN_USE_PREINIT_ARRAY 1 # define SANITIZER_CAN_USE_PREINIT_ARRAY 1
#else #else
# define SANITIZER_CAN_USE_PREINIT_ARRAY 0 # define SANITIZER_CAN_USE_PREINIT_ARRAY 0
#endif #endif
▲ Show 20 Lines • Show All 320 Lines • Show Last 20 Lines