This is an archive of the discontinued LLVM Phabricator instance.

[ELF][test] Use llvm-readelf's short option -r instead of -relocations and remove ignored --wide
ClosedPublic

Authored by MaskRay on Sep 14 2018, 3:02 PM.

Event Timeline

MaskRay created this revision.Sep 14 2018, 3:02 PM
ruiu added a comment.Sep 14 2018, 3:15 PM

Is -r a hidden option of llvm-readelf? llvm-readelf --help doesn't show that option.

ruiu added a comment.Sep 14 2018, 5:18 PM

I don't feel comfortable about using an option that is not shown in the --help message, so either add it to the help message or just leave them as is.

Thanks for doing this. I didn't realize we got the wide behavior by default with llvm-readelf.

Shall we proceed with this? These llvm-readelf short options are listed in -help since rL342339 and -r has been used in llvm-readobj (e.g. ELF/lto/relocation-model.ll) llvm-objdump.

ruiu accepted this revision.Sep 26 2018, 12:43 PM

LGTM

This revision is now accepted and ready to land.Sep 26 2018, 12:43 PM
This revision was automatically updated to reflect the committed changes.