Page MenuHomePhabricator

[clangd] Cleanup FuzzyFindRequest filtering limit semantics
ClosedPublic

Authored by kbobyrev on Sep 13 2018, 5:52 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Sep 13 2018, 5:52 AM
sammccall accepted this revision.Sep 13 2018, 6:11 AM

Thanks!

clang-tools-extra/clangd/index/Index.h
477 ↗(On Diff #165261)

nit: 'Req.Limit' would fit on the line

clang-tools-extra/clangd/index/dex/Dex.cpp
182 ↗(On Diff #165261)

wow, this was overflowing!
I guess harmlessly to... numeric_limits<uint32>::max() - 99 or something? weird.

This revision is now accepted and ready to land.Sep 13 2018, 6:11 AM
kbobyrev updated this revision to Diff 165271.Sep 13 2018, 6:47 AM
kbobyrev marked an inline comment as done.

Change IndexBenchmark accordingly, perform minor cleanup.

clang-tools-extra/clangd/index/dex/Dex.cpp
182 ↗(On Diff #165261)

Oh, yeah, good catch! I thought I had some workaround at some point, but seems that it was lost at some point.

kbobyrev updated this revision to Diff 165272.Sep 13 2018, 6:50 AM

Don't modify benchmarks since it'd clash with the parent patch in this case.

kbobyrev updated this revision to Diff 165283.Sep 13 2018, 7:27 AM

Update requests.json to comply with the new format.

This revision was automatically updated to reflect the committed changes.