This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Clarify and hide -index flag.
ClosedPublic

Authored by ioeric on Sep 12 2018, 4:56 AM.

Details

Summary

The wording implies global index support, which is confusing.
As most users shouldn't care about this flag, also make it hidden to avoid
further confusion.

Event Timeline

ioeric created this revision.Sep 12 2018, 4:56 AM
ilya-biryukov accepted this revision.Sep 12 2018, 7:37 AM

+1 to making this hidden. Users (most of them) shouldn't care about it.
Is there any motivation on why we someone would want to disable it currently? Maybe we want to deprecate it and remove it completely at some point?
I could only think of being as close as possible to sema completions, but that doesn't seem like something that gives better UX (folks from Apple might be interested in that, but not sure).

LGTM from my side.

clangd/tool/ClangdMain.cpp
135

Maybe replace static/global with simply "Global" or "Project-wide".
I think it's good that we don't mention "dynamic" and "static" index in the docs too much, users shouldn't really care about this terminology.

This revision is now accepted and ready to land.Sep 12 2018, 7:37 AM
ioeric updated this revision to Diff 165263.Sep 13 2018, 5:54 AM
ioeric marked an inline comment as done.
  • Remove static.
This revision was automatically updated to reflect the committed changes.