Page MenuHomePhabricator

[clangd] NFC: Change quality type to float
ClosedPublic

Authored by kbobyrev on Sep 4 2018, 8:18 AM.

Details

Summary

For the sake of consistency, quality() should return float instead of double since all of the scoring calculation happens to be in floats. This should address a concern raised in D51481.

Diff Detail

Event Timeline

kbobyrev created this revision.Sep 4 2018, 8:18 AM
kbobyrev edited the summary of this revision. (Show Details)Sep 4 2018, 8:18 AM
kbobyrev edited the summary of this revision. (Show Details)
sammccall accepted this revision.Sep 4 2018, 8:22 AM

If it's not too expensive, we can use the symbol quality metrics (from Quality.h) to do a more accurate prescore. Worth a benchmark :-)

This revision is now accepted and ready to land.Sep 4 2018, 8:22 AM

If it's not too expensive, we can use the symbol quality metrics (from Quality.h) to do a more accurate prescore. Worth a benchmark :-)

Yes, I agree. We can investigate that quality/performance trade-off when we have more tools to simplify the process :)

This revision was automatically updated to reflect the committed changes.