[Driver] Change MipsLinux default linker from "lld" to "ld.lld"

[atanasyan]

LGTM

[ruiu]

If this piece of code used to be working correctly, there is another piece of code that adds -flavor ld to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept -flavor option.

So my guess is this code is dead. Or, am I missing something?

[atanasyan]

In D51234#1213813, @ruiu wrote:

If this piece of code used to be working correctly, there is another piece of code that adds -flavor ld to the command line. But if that's the case, this change wouldn't work because it constructs something like "ld.lld -flavor ld ...". ld.lld doesn't accept -flavor option.

So my guess is this code is dead. Or, am I missing something?

The tools::gnutools::Linker::ConstructJob method contains code which adds -flavor old-gnu command line option if linker name is "lld". Probably this code can be removed now.

lib/Driver/ToolChains/MipsLinux.h

public:
   std::string computeSysRoot() const override;
 
   RuntimeLibType GetDefaultRuntimeLibType() const override {
     return GCCInstallation.isValid() ? RuntimeLibType::RLT_Libgcc
                                      : RuntimeLibType::RLT_CompilerRT;
   }
 
   const char *getDefaultLinker() const override {
-    return "lld";
+    return "ld.lld";
   }
 
 private:
   Multilib SelectedMultilib;
   std::string LibSuffix;
 };
 
 } // end namespace toolchains
 } // end namespace driver
 } // end namespace clang
 
 #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_MIPS_LINUX_H