This makes it conform to what the comment says. Otherwise when getErrPlace() is called afterwards, cast<InputSection>(D) will cause incompatible cast as MergeInputSection is not a subclass of InputSection.
Details
Details
- Reviewers
ruiu grimar • espindola pcc - Commits
- rGea525abfcbeb: Merging r339904: --------------------------------------------------------------…
rGebf9607d7dd0: [ELF] mergeSections: remove non-alive MergeInputSection
rL339986: Merging r339904:
rLLD339904: [ELF] mergeSections: remove non-alive MergeInputSection
rL339904: [ELF] mergeSections: remove non-alive MergeInputSection
Diff Detail
Diff Detail
- Repository
- rLLD LLVM Linker
- Build Status
Buildable 21525 Build 21525: arc lint + arc unit
Event Timeline
Comment Actions
Update description with arc diff --edit --verbatim (see if this updates the Phabricator summary)
Comment Actions
I don't know how to add a test checking the elements of InputSections.
Alternatively, I can check whether getErrorPlace will cause cast<> assertion failure. But how can I make it error?
Comment Actions
LGTM with a nit.
test/ELF/x86-64-reloc-error2.s | ||
---|---|---|
20 | You do not need to reveal the implementation details in the test cases. All you need is to say is something like: |
You do not need to reveal the implementation details in the test cases.
They might change and will make such comment outdated.
All you need is to say is something like:
"This mergeable section will be garbage collected. We had a crash issue in that case. Test it."