This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] SIMD encoding tests
ClosedPublic

Authored by tlively on Aug 13 2018, 1:04 PM.

Details

Summary

Modifies existing SIMD tests to also check that SIMD instructions are
lowered to the expected bytes. This CL depends on D50597.

Patch by Thomas Lively

Diff Detail

Event Timeline

tlively created this revision.Aug 13 2018, 1:04 PM

Didn't know llc has --show-mc-encoding option! πŸ‘ Probably we should start using this elsewhere too.

test/CodeGen/WebAssembly/simd-arith.ll
21

Do we need # at the end here?

tlively added inline comments.Aug 13 2018, 6:38 PM
test/CodeGen/WebAssembly/simd-arith.ll
21

Not really. One option is to complete the line ; SIMD128: return $pop0 # encoding: [0x0f], Another is to just stop with the $pop0. I had added the # because the test had previously checked for end of line and I didn't want to weaken the test too much.

aheejin accepted this revision.Aug 14 2018, 10:57 AM
This revision is now accepted and ready to land.Aug 14 2018, 10:57 AM
aheejin added inline comments.Aug 14 2018, 11:51 AM
test/CodeGen/WebAssembly/simd-arith.ll
0–6

Change -wasm-register-codegen-test-mode to the old option here too

tlively updated this revision to Diff 160662.Aug 14 2018, 12:06 PM
  • Fix llc arguments
tlively marked an inline comment as done.Aug 14 2018, 12:07 PM
This revision was automatically updated to reflect the committed changes.