Diff Detail
Diff Detail
Event Timeline
Comment Actions
Adding more potential reviewers.
I don't know how to read AMDGPU output. Is it possible to expose the difference on x86 or AArch64? Or use MIR tests, so we're just seeing the expected DAG node names?
Comment Actions
MIR tests don't work for the DAG. The important part is emitting v_pk_max_f16 for the v2f16/v4f16 for the GFX9-NNAN cases. I need to look into why this still doesn't work as expected for the v8f16 case
Comment Actions
LGTM - not sure if its any better to split fmin_fmax_legacy.f16.ll into fmin_legacy.f16.ll and fmax_legacy.f16.ll - I find it sometimes useful to be able to diff these types of related test files against one another?
lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
7295 | This bit can be comitted first as a NFC helper change? |
This bit can be comitted first as a NFC helper change?