This is an archive of the discontinued LLVM Phabricator instance.

Differential D50350

Port getLocStart -> getBeginLoc
ClosedPublic

Authored by steveire on Aug 6 2018, 12:43 PM.

Details

Reviewers
teemperor
rsmith
steveire
Commits
rGf2ceec4811c3: Port getLocStart -> getBeginLoc
rL339385: Port getLocStart -> getBeginLoc
rC339385: Port getLocStart -> getBeginLoc

Diff Detail

Event Timeline

steveire created this revision.Aug 6 2018, 12:43 PM
Herald added a reviewer: teemperor. · View Herald TranscriptAug 6 2018, 12:43 PM
Herald added subscribers: cfe-commits, jfb, whisperity, jholewinski. · View Herald Transcript
Harbormaster completed remote builds in B21139: Diff 159361.Aug 6 2018, 12:44 PM
steveire added a reviewer: rsmith.Aug 6 2018, 12:50 PM
steveire added a comment.Aug 9 2018, 1:41 PM

Accepted as part of a whole-branch review here: http://clang-developers.42468.n3.nabble.com/getLocStart-versus-getStartLoc-td4061010.html

steveire accepted this revision.Aug 9 2018, 1:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2018, 2:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rC339385: Port getLocStart -> getBeginLoc (authored by steveire). · Explain Why
Closed by commit rL339385: Port getLocStart -> getBeginLoc (authored by steveire). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 9 2018, 2:09 PM

Large Diff

This large diff affects 147 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
docs/
4 lines
include/
clang/
AST/
18 lines
2 lines
4 lines
2 lines
4 lines
26 lines
34 lines
12 lines
2 lines
2 lines
2 lines
2 lines
6 lines
2 lines
ASTMatchers/
6 lines
Sema/
6 lines
StaticAnalyzer/
Core/
BugReporter/
2 lines
lib/
ARCMigrate/
30 lines
2 lines
14 lines
2 lines
4 lines
8 lines
12 lines
2 lines
AST/
4 lines
2 lines
46 lines
10 lines
10 lines
2 lines
2 lines
2 lines
30 lines
12 lines
44 lines
12 lines
4 lines
14 lines
2 lines
Analysis/
6 lines
2 lines
8 lines
2 lines
20 lines
8 lines
CodeGen/
2 lines
8 lines
6 lines
6 lines
4 lines
12 lines
4 lines
4 lines
10 lines
2 lines
4 lines
4 lines
24 lines
16 lines
12 lines
156 lines
6 lines
6 lines
2 lines
6 lines
4 lines
Edit/
8 lines
Frontend/
Rewrite/
106 lines
88 lines
Index/
6 lines
2 lines
2 lines
Parse/
2 lines
2 lines
2 lines
8 lines
2 lines
Sema/
78 lines
16 lines
10 lines
4 lines
16 lines
380 lines
4 lines
86 lines
58 lines
112 lines
22 lines
4 lines
180 lines
62 lines
92 lines
170 lines
12 lines
2 lines
8 lines
150 lines
124 lines
2 lines
50 lines
52 lines
8 lines
106 lines
6 lines
4 lines
28 lines
4 lines
52 lines
264 lines
Serialization/
18 lines
2 lines
14 lines
4 lines
StaticAnalyzer/
Checkers/
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
6 lines
2 lines
2 lines
Core/
4 lines
18 lines
2 lines
18 lines
2 lines
18 lines
4 lines
Frontend/
2 lines
Tooling/
Refactoring/
Extract/
4 lines
Rename/
2 lines
6 lines
tools/
clang-func-mapping/
2 lines
libclang/
28 lines
2 lines
unittests/
Tooling/
2 lines
4 lines
RecursiveASTVisitorTests/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 159361

docs/RAVFrontendAction.rst

include/clang/AST/Comment.h

include/clang/AST/Decl.h

include/clang/AST/DeclCXX.h

include/clang/AST/DeclObjC.h

include/clang/AST/DeclarationName.h

include/clang/AST/Expr.h

include/clang/AST/ExprCXX.h

include/clang/AST/ExprObjC.h

include/clang/AST/ExprOpenMP.h

include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h

include/clang/AST/RawCommentList.h

include/clang/AST/Stmt.h

include/clang/AST/StmtCXX.h

include/clang/AST/StmtDataCollectors.td

include/clang/ASTMatchers/ASTMatchers.h

include/clang/Sema/Initialization.h

include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h

lib/ARCMigrate/ObjCMT.cpp

lib/ARCMigrate/TransAPIUses.cpp

lib/ARCMigrate/TransAutoreleasePool.cpp

lib/ARCMigrate/TransGCCalls.cpp

lib/ARCMigrate/TransProtectedScope.cpp

lib/ARCMigrate/TransRetainReleaseDealloc.cpp

lib/ARCMigrate/TransUnbridgedCasts.cpp

lib/ARCMigrate/TransformActions.cpp

lib/AST/ASTContext.cpp

lib/AST/ASTDumper.cpp

lib/AST/ASTImporter.cpp

lib/AST/ASTStructuralEquivalence.cpp

lib/AST/Decl.cpp

lib/AST/DeclObjC.cpp

lib/AST/DeclOpenMP.cpp

lib/AST/DeclTemplate.cpp

lib/AST/Expr.cpp

lib/AST/ExprCXX.cpp

lib/AST/ExprConstant.cpp

lib/AST/RawCommentList.cpp

lib/AST/SelectorLocationsKind.cpp

lib/AST/Stmt.cpp

lib/AST/StmtPrinter.cpp

lib/Analysis/AnalysisDeclContext.cpp

lib/Analysis/CloneDetection.cpp

lib/Analysis/Consumed.cpp

lib/Analysis/LiveVariables.cpp

lib/Analysis/ReachableCode.cpp

lib/Analysis/ThreadSafety.cpp

lib/CodeGen/CGAtomic.cpp

lib/CodeGen/CGBlocks.cpp

lib/CodeGen/CGBuiltin.cpp

lib/CodeGen/CGCall.cpp

lib/CodeGen/CGClass.cpp

lib/CodeGen/CGCoroutine.cpp

lib/CodeGen/CGDeclCXX.cpp

lib/CodeGen/CGException.cpp

lib/CodeGen/CGExpr.cpp

lib/CodeGen/CGExprCXX.cpp

lib/CodeGen/CGExprScalar.cpp

lib/CodeGen/CGObjC.cpp

lib/CodeGen/CGOpenMPRuntime.cpp

lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp

lib/CodeGen/CGStmt.cpp

lib/CodeGen/CGStmtOpenMP.cpp

lib/CodeGen/CodeGenFunction.cpp

lib/CodeGen/CodeGenModule.cpp

lib/CodeGen/CodeGenPGO.cpp

lib/CodeGen/CoverageMappingGen.cpp

lib/CodeGen/ItaniumCXXABI.cpp

lib/Edit/RewriteObjCFoundationAPI.cpp

lib/Frontend/Rewrite/RewriteModernObjC.cpp

lib/Frontend/Rewrite/RewriteObjC.cpp

lib/Index/IndexBody.cpp

lib/Index/IndexDecl.cpp

lib/Index/USRGeneration.cpp

lib/Parse/ParseDecl.cpp

lib/Parse/ParseExpr.cpp

lib/Parse/ParseExprCXX.cpp

lib/Parse/ParseObjc.cpp

lib/Parse/ParseStmt.cpp

lib/Sema/AnalysisBasedWarnings.cpp

lib/Sema/JumpDiagnostics.cpp

lib/Sema/Sema.cpp

lib/Sema/SemaAttr.cpp

lib/Sema/SemaCast.cpp

lib/Sema/SemaChecking.cpp

lib/Sema/SemaCoroutine.cpp

lib/Sema/SemaDecl.cpp

lib/Sema/SemaDeclAttr.cpp

lib/Sema/SemaDeclCXX.cpp

lib/Sema/SemaDeclObjC.cpp

lib/Sema/SemaExceptionSpec.cpp

lib/Sema/SemaExpr.cpp

lib/Sema/SemaExprCXX.cpp

lib/Sema/SemaExprObjC.cpp

lib/Sema/SemaInit.cpp

lib/Sema/SemaLambda.cpp

lib/Sema/SemaLookup.cpp

lib/Sema/SemaObjCProperty.cpp

lib/Sema/SemaOpenMP.cpp

lib/Sema/SemaOverload.cpp

lib/Sema/SemaPseudoObject.cpp

lib/Sema/SemaStmt.cpp

lib/Sema/SemaStmtAsm.cpp

lib/Sema/SemaStmtAttr.cpp

lib/Sema/SemaTemplate.cpp

lib/Sema/SemaTemplateDeduction.cpp

lib/Sema/SemaTemplateInstantiate.cpp

lib/Sema/SemaTemplateInstantiateDecl.cpp

lib/Sema/SemaTemplateVariadic.cpp

lib/Sema/SemaType.cpp

lib/Sema/TreeTransform.h

lib/Serialization/ASTReader.cpp

lib/Serialization/ASTWriter.cpp

lib/Serialization/ASTWriterDecl.cpp

lib/Serialization/ASTWriterStmt.cpp

lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp

lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp

lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp

lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp

lib/StaticAnalyzer/Checkers/ObjCUnusedIVarsChecker.cpp

lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp

lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp

lib/StaticAnalyzer/Checkers/TraversalChecker.cpp

lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp

lib/StaticAnalyzer/Core/BugReporter.cpp

lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

lib/StaticAnalyzer/Core/CheckerHelpers.cpp

lib/StaticAnalyzer/Core/ExprEngine.cpp

lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp

lib/StaticAnalyzer/Core/PathDiagnostic.cpp

lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp

lib/Tooling/Refactoring/Extract/Extract.cpp

lib/Tooling/Refactoring/Rename/USRFinder.cpp

lib/Tooling/Refactoring/Rename/USRLocFinder.cpp

tools/clang-func-mapping/ClangFnMapGen.cpp

tools/libclang/CIndex.cpp

tools/libclang/CXIndexDataConsumer.cpp

unittests/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp

unittests/Tooling/RecursiveASTVisitorTestDeclVisitor.cpp

unittests/Tooling/RecursiveASTVisitorTests/Attr.cpp

unittests/Tooling/RecursiveASTVisitorTests/CXXMemberCall.cpp

unittests/Tooling/RecursiveASTVisitorTests/InitListExprPostOrder.cpp

unittests/Tooling/RecursiveASTVisitorTests/InitListExprPostOrderNoQueue.cpp

unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrder.cpp

unittests/Tooling/RecursiveASTVisitorTests/InitListExprPreOrderNoQueue.cpp