[llvm-objcopy] Make --strip-debug strip .gdb_index

[MaskRay]

Summary

See binutils-gdb/bfd/elf.c, GNU objcopy also strips .stab* (STABS)
.line* (DWARF 1) .gnu.linkonce.wi.* (linkonce section for .debug_info) but
I'm not sure we need to be compatible with it.

[jakehehrlich]

Can we add test? Otherwise this LGTM.

[MaskRay]

Add test

[alexander-shaposhnikov]

LG

[jakehehrlich]

test/tools/llvm-objcopy/strip-debug.test

94 ↗

(On Diff #158374)

This wasn't a typeo, it was put there on purpose to test that anything start with ".debug" would trigger

[MaskRay]

Use .debugfoo and .zdebugfoo

tools/llvm-objcopy/llvm-objcopy.cpp

LLVM_ATTRIBUTE_NORETURN void reportError(StringRef File, Error E) {
   errs() << ToolName << ": '" << File << "': " << Buf;
   exit(1);
 }
 
 } // end namespace objcopy
 } // end namespace llvm
 
 static bool IsDebugSection(const SectionBase &Sec) {
-  return Sec.Name.startswith(".debug") || Sec.Name.startswith(".zdebug");
+  return Sec.Name.startswith(".debug") || Sec.Name.startswith(".zdebug") ||
+         Sec.Name == ".gdb_index";
 }
 
 static bool IsDWOSection(const SectionBase &Sec) {
   return Sec.Name.endswith(".dwo");
 }
 
 static bool OnlyKeepDWOPred(const Object &Obj, const SectionBase &Sec) {
   // We can't remove the section header string table.