This is an archive of the discontinued LLVM Phabricator instance.

Differential D50086

[OMPT] Disable by default on Windows
ClosedPublic

Authored by Hahnfeld on Jul 31 2018, 10:53 AM.

Details

Reviewers
protze.joachim
hbae
jlpeyton
AndreyChurbanov
omalyshe
Commits
rGe6324b725afd: Merging r338721: --------------------------------------------------------------…
rGef8f73728858: [OMPT] Disable by default on Windows
rL338728: Merging r338721:
rOMP338721: [OMPT] Disable by default on Windows
rL338721: [OMPT] Disable by default on Windows
Summary

This is broken per PR36561 and PR36574, so disable it for now until
somebody interested can take a look. OMPT can still be activated manually
by passing -DLIBOMP_OMPT_SUPPORT=ON during configuration.

Diff Detail

Event Timeline

Hahnfeld created this revision.Jul 31 2018, 10:53 AM
Herald added subscribers: openmp-commits, mgorny. · View Herald TranscriptJul 31 2018, 10:53 AM
protze.joachim accepted this revision.Jul 31 2018, 1:23 PM

I second this change, since this should hopefully allow to include OpenMP in the release build, until someone can fix the build of OMPT on Windows.

This revision is now accepted and ready to land.Jul 31 2018, 1:23 PM
Hahnfeld added a reviewer: omalyshe.Jul 31 2018, 11:21 PM
Hahnfeld added a comment.Aug 2 2018, 1:38 AM

If nobody objects I'd like to commit this later today and try to get this backported before rc1.

omalyshe accepted this revision.Aug 2 2018, 1:54 AM
Closed by commit rL338721: [OMPT] Disable by default on Windows (authored by Hahnfeld). · Explain WhyAug 2 2018, 7:34 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 2 2018, 7:34 AM

Revision Contents

PathSize
2 lines
runtime/
2 lines

Diff 158326

README.rst

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
**LIBOMP_USE_INTERNODE_ALIGNMENT** = ``OFF|ON`` **LIBOMP_USE_INTERNODE_ALIGNMENT** = ``OFF|ON``
Align certain data structures on 4096-byte. This option is useful on Align certain data structures on 4096-byte. This option is useful on
multi-node systems where a small ``CACHE_LINE`` setting leads to false sharing. multi-node systems where a small ``CACHE_LINE`` setting leads to false sharing.
**LIBOMP_OMPT_SUPPORT** = ``ON|OFF`` **LIBOMP_OMPT_SUPPORT** = ``ON|OFF``
Include support for the OpenMP Tools Interface (OMPT). Include support for the OpenMP Tools Interface (OMPT).
This option is supported and ``ON`` by default for x86, x86_64, AArch64, and This option is supported and ``ON`` by default for x86, x86_64, AArch64, and
PPC64 on Linux*, Windows*, and macOS*. PPC64 on Linux* and macOS*.
This option is ``OFF`` if this feature is not supported for the platform. This option is ``OFF`` if this feature is not supported for the platform.
**LIBOMP_OMPT_OPTIONAL** = ``ON|OFF`` **LIBOMP_OMPT_OPTIONAL** = ``ON|OFF``
Include support for optional OMPT functionality. This option is ignored if Include support for optional OMPT functionality. This option is ignored if
**LIBOMP_OMPT_SUPPORT** is ``OFF``. **LIBOMP_OMPT_SUPPORT** is ``OFF``.
**LIBOMP_STATS** = ``OFF|ON`` **LIBOMP_STATS** = ``OFF|ON``
Include stats-gathering code. Include stats-gathering code.
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines

runtime/CMakeLists.txt

Show First 20 Lines • Show All 296 Lines • ▼ Show 20 Lines
if(LIBOMP_USE_VERSION_SYMBOLS AND (NOT LIBOMP_ENABLE_SHARED) ) if(LIBOMP_USE_VERSION_SYMBOLS AND (NOT LIBOMP_ENABLE_SHARED) )
message(STATUS "Version symbols not supported for static libraries - forcing Version symbols functionality off") message(STATUS "Version symbols not supported for static libraries - forcing Version symbols functionality off")
set (LIBOMP_USE_VERSION_SYMBOLS FALSE) set (LIBOMP_USE_VERSION_SYMBOLS FALSE)
endif() endif()
# OMPT-support defaults to ON for OpenMP 5.0+ and if the requirements in # OMPT-support defaults to ON for OpenMP 5.0+ and if the requirements in
# cmake/config-ix.cmake are fulfilled. # cmake/config-ix.cmake are fulfilled.
set(OMPT_DEFAULT FALSE) set(OMPT_DEFAULT FALSE)
if ((${LIBOMP_OMP_VERSION} GREATER 49) AND (LIBOMP_HAVE_OMPT_SUPPORT)) if ((${LIBOMP_OMP_VERSION} GREATER 49) AND (LIBOMP_HAVE_OMPT_SUPPORT) AND (NOT WIN32))
set(OMPT_DEFAULT TRUE) set(OMPT_DEFAULT TRUE)
endif() endif()
set(LIBOMP_OMPT_SUPPORT ${OMPT_DEFAULT} CACHE BOOL set(LIBOMP_OMPT_SUPPORT ${OMPT_DEFAULT} CACHE BOOL
"OMPT-support?") "OMPT-support?")
set(LIBOMP_OMPT_DEBUG FALSE CACHE BOOL set(LIBOMP_OMPT_DEBUG FALSE CACHE BOOL
"Trace OMPT initialization?") "Trace OMPT initialization?")
set(LIBOMP_OMPT_OPTIONAL TRUE CACHE BOOL set(LIBOMP_OMPT_OPTIONAL TRUE CACHE BOOL
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines