User Details
- User Since
- Apr 10 2015, 6:24 AM (372 w, 6 h)
Aug 2 2018
Feb 21 2018
Do we really need this change?
I found a comment from John M-C at https://github.com/OpenMPToolsInterface/OpenMP-4.5-spec/commit/7bed0e0e6b96e0cfa6d964de2101c2172a0a47e7#commitcomment-24561958 (that commit replaced ompt_frame_t to omp_frame_t in the Spec):
Feb 19 2018
Feb 15 2018
Feb 14 2018
This doesn't work, parallel_id=0 for these two events
Implemented changes look good.
LGTM.
Found a small issue with CHECK.
All other LGTM.
Feb 8 2018
Feb 7 2018
Jan 31 2018
Jan 29 2018
Jan 25 2018
FAIL: libomp :: ompt/misc/control_tool_no_ompt_support.c (66 of 161)
- TEST 'libomp :: ompt/misc/control_tool_no_ompt_support.c' FAILED ****
Script:
C:/src/llvm/build.release/./bin/clang.exe -fopenmp -I C:/src/llvm/projects/openmp/runtime/test -I C:/src/llvm/build.release/projects/openmp/runtime/src -L C:/src/llvm/build.release/bin C:\src\llvm\projects\openmp\runtime\test\ompt\misc\control_tool_no_ompt_support.c -o C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp && C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp
There was no NEEDS line in that file. Does omp50 get defined anywhere? Grepping the OpenMP repository for it yields no matches.
Jan 24 2018
Intel is saying that they do extensive testing of the runtime - whatever that means on Windows...
Currently we have limited testing of OMPT features on Windows.
Jan 22 2018
LGTM
Dec 22 2017
LGTM.
Verified on some other tests in Intel environment.
Dec 21 2017
LGTM.
Dec 14 2017
Should we add a test for the case ompt_* calls from non-OpenMP thread?
icc bug
What bug it is and which version of ICC is affected?
Dec 6 2017
So maybe @omalyshe can convince the compiler team to add the macros that would simplify life? :-)
Compiler itself somehow cope with it when printing the version. I'll try find out- how.
$ icc -V
Intel(R) C Intel(R) 64 Compiler for applications running on Intel(R) 64, Version 18.0 Build 20171115
Copyright (C) 1985-2017 Intel Corporation. All rights reserved.
Nov 30 2017
I failed to specify a test compiler with previous LIBOMP_TEST_* staff because I tried -DLIBOMP_TEST_C_COMPILER=gcc but it actually should have been -DLIBOMP_TEST_COMPILER=gcc. Somehow the old macro had _<lang>_ part missed ;)
It works for me now and I believe it will work for OPENMP_TEST_* too.
Thank you!
Why do we limit the test compiler to be the same as the build compiler for libomp?
CMAKE_TEST_<lang>_COMPILER option would be useful to be able to run tests with different compilers.
Fix for non-hwloc build
Nov 29 2017
Nov 22 2017
Nov 21 2017
Nov 10 2017
Nov 8 2017
Oct 31 2017
Oct 18 2017
Oct 17 2017
LGTM.
Oct 4 2017
Oct 3 2017
Sep 29 2017
Aug 2 2017
Jul 18 2017
LGTM.
Apr 4 2017
Added test case for the loop construct with '#pragma omp cancel' followed by the sections construct with cancellation point
Mar 28 2017
LGTM.
Mar 1 2017
Feb 28 2017
Feb 27 2017
Oct 11 2016
Updated the diff to address Jonathan's comment.
Oct 5 2016
Sep 20 2016
Aug 29 2016
May 23 2016
The full diff attached.
Apr 13 2016
LGTM.
Mar 24 2016
LGTM.
LGTM.
Mar 15 2016
LGTM.
Feb 26 2016
Is it OK that ompt_parallel_id_new() is called several times for one region? First in line 393 and then inside kmp_serialized_parallel() it can be called once or twice.
Sep 21 2015
Sep 17 2015
Aug 5 2015
Jul 1 2015
Jun 29 2015
LGTM.
Apr 29 2015
LGTM. Can be committed.
Apr 27 2015
LGTM. Please, commit.