Page MenuHomePhabricator

omalyshe (Olga Malysheva)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 10 2015, 6:24 AM (222 w, 5 d)

Recent Activity

Aug 2 2018

omalyshe accepted D50086: [OMPT] Disable by default on Windows.
Aug 2 2018, 1:55 AM

Feb 21 2018

omalyshe added a comment to D43568: [OMPT] Rename ompt_frame_t to omp_frame_t.

Do we really need this change?
I found a comment from John M-C at https://github.com/OpenMPToolsInterface/OpenMP-4.5-spec/commit/7bed0e0e6b96e0cfa6d964de2101c2172a0a47e7#commitcomment-24561958 (that commit replaced ompt_frame_t to omp_frame_t in the Spec):

Feb 21 2018, 5:45 AM

Feb 19 2018

omalyshe accepted D43115: [OMPT] Fix inconsistent testcases.

LGTM.

Feb 19 2018, 3:31 AM
omalyshe added inline comments to D43115: [OMPT] Fix inconsistent testcases.
Feb 19 2018, 2:09 AM

Feb 15 2018

omalyshe accepted D41942: [OMPT] Add interoperability testcase.

LGTM.

Feb 15 2018, 3:38 AM

Feb 14 2018

omalyshe added a comment to D43191: [OMPT] Fix test tasks/serialized.c with optimization.

This doesn't work, parallel_id=0 for these two events

Feb 14 2018, 8:11 AM
omalyshe added a comment to D41942: [OMPT] Add interoperability testcase.

Implemented changes look good.

Feb 14 2018, 5:40 AM
omalyshe accepted D43190: [OMPT][test] Correct warning about added wrapper functions.

LGTM.

Feb 14 2018, 1:44 AM
omalyshe added a comment to D43191: [OMPT] Fix test tasks/serialized.c with optimization.

Found a small issue with CHECK.
All other LGTM.

Feb 14 2018, 1:33 AM

Feb 8 2018

omalyshe added a comment to D41942: [OMPT] Add interoperability testcase.

I think if you re-capture a variable with FileCheck that's the same as capturing another variable except that you can't use the old value. So I'm not sure if the changes make any difference, besides naming...

Feb 8 2018, 2:04 AM
omalyshe requested changes to D41942: [OMPT] Add interoperability testcase.
Feb 8 2018, 1:11 AM

Feb 7 2018

omalyshe added inline comments to D42162: [OMPT] Update api_calls testcase.
Feb 7 2018, 7:16 AM
omalyshe added inline comments to D42162: [OMPT] Update api_calls testcase.
Feb 7 2018, 7:08 AM

Jan 31 2018

omalyshe accepted D42709: [OMPT] Fix tool initialization returning 0.

LGTM.

Jan 31 2018, 3:58 AM

Jan 29 2018

omalyshe added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Jan 29 2018, 1:03 AM · Restricted Project

Jan 25 2018

omalyshe added a comment to D42427: Fix broken OpenMP runtime test cases for Windows.

FAIL: libomp :: ompt/misc/control_tool_no_ompt_support.c (66 of 161)

  • TEST 'libomp :: ompt/misc/control_tool_no_ompt_support.c' FAILED ****

Script:

C:/src/llvm/build.release/./bin/clang.exe -fopenmp -I C:/src/llvm/projects/openmp/runtime/test -I C:/src/llvm/build.release/projects/openmp/runtime/src -L C:/src/llvm/build.release/bin C:\src\llvm\projects\openmp\runtime\test\ompt\misc\control_tool_no_ompt_support.c -o C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp && C:\src\llvm\build.release\projects\openmp\runtime\test\ompt\misc\Output\control_tool_no_ompt_support.c.tmp

Jan 25 2018, 7:32 AM
omalyshe added a comment to D42427: Fix broken OpenMP runtime test cases for Windows.

There was no NEEDS line in that file. Does omp50 get defined anywhere? Grepping the OpenMP repository for it yields no matches.

Jan 25 2018, 6:39 AM
omalyshe added a comment to D42427: Fix broken OpenMP runtime test cases for Windows.
In D42427#987666, @hans wrote:

This works for me if the NEEDS are replaced with REQUIRES.

ompt/misc/control_tool_no_ompt_support.c still fails though:

Jan 25 2018, 5:00 AM
omalyshe added a comment to D42427: Fix broken OpenMP runtime test cases for Windows.

@omalyshe do you have any advice, what is needed to make the omp_control_tool symbol available on Windows?

My naive approach was to follow the things done for omp_get_thread_num.

Jan 25 2018, 4:34 AM

Jan 24 2018

omalyshe added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

Intel is saying that they do extensive testing of the runtime - whatever that means on Windows...

Currently we have limited testing of OMPT features on Windows.

Jan 24 2018, 12:58 AM

Jan 22 2018

omalyshe accepted D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library.

LGTM

Jan 22 2018, 11:00 PM
omalyshe added inline comments to D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library.
Jan 22 2018, 10:53 PM
omalyshe added inline comments to D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library.
Jan 22 2018, 10:24 PM
omalyshe added inline comments to D42352: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library.
Jan 22 2018, 5:29 AM

Dec 22 2017

omalyshe accepted D41504: Remove unused positional argument for printf.

LGTM.
Verified on some other tests in Intel environment.

Dec 22 2017, 5:36 AM

Dec 21 2017

omalyshe accepted D40920: Unify build documentation and convert to reStructuredText.

LGTM.

Dec 21 2017, 10:30 PM
omalyshe requested changes to D40920: Unify build documentation and convert to reStructuredText.
Dec 21 2017, 4:21 AM

Dec 14 2017

omalyshe added a comment to D41167: [OMPT] Return appropiate values for ompt runtime entry points when the current thread is not an OpenMP thread.

Should we add a test for the case ompt_* calls from non-OpenMP thread?

Dec 14 2017, 8:09 AM
omalyshe added a comment to D41182: [OMPT] Add Workaround for Intel Compiler Bug.
icc bug

What bug it is and which version of ICC is affected?

Dec 14 2017, 8:07 AM

Dec 6 2017

omalyshe added a comment to D40386: [OpenMP] Add entry for Intel Compiler 18.

So maybe @omalyshe can convince the compiler team to add the macros that would simplify life? :-)

Compiler itself somehow cope with it when printing the version. I'll try find out- how.
$ icc -V
Intel(R) C Intel(R) 64 Compiler for applications running on Intel(R) 64, Version 18.0 Build 20171115
Copyright (C) 1985-2017 Intel Corporation. All rights reserved.

Dec 6 2017, 12:07 AM

Nov 30 2017

omalyshe accepted D40083: [CMake] Detect information about test compiler.

LGTM.

Nov 30 2017, 8:24 AM
omalyshe added a comment to D40083: [CMake] Detect information about test compiler.

You should still be able to set OPENMP_TEST_C_COMPILER and OPENMP_TEST_CXX_COMPILER as before.

I failed to specify a test compiler with previous LIBOMP_TEST_* staff because I tried -DLIBOMP_TEST_C_COMPILER=gcc but it actually should have been -DLIBOMP_TEST_COMPILER=gcc. Somehow the old macro had _<lang>_ part missed ;)
It works for me now and I believe it will work for OPENMP_TEST_* too.
Thank you!

Yes, I fixed that inconsistency in the previous refactoring. But I'm a bit confused because LIBOMP_TEST_* shouldn't work anymore?

Nov 30 2017, 8:18 AM
omalyshe added a comment to D40083: [CMake] Detect information about test compiler.

You should still be able to set OPENMP_TEST_C_COMPILER and OPENMP_TEST_CXX_COMPILER as before.

I failed to specify a test compiler with previous LIBOMP_TEST_* staff because I tried -DLIBOMP_TEST_C_COMPILER=gcc but it actually should have been -DLIBOMP_TEST_COMPILER=gcc. Somehow the old macro had _<lang>_ part missed ;)
It works for me now and I believe it will work for OPENMP_TEST_* too.
Thank you!

Nov 30 2017, 7:56 AM
omalyshe added a comment to D40083: [CMake] Detect information about test compiler.

Why do we limit the test compiler to be the same as the build compiler for libomp?
CMAKE_TEST_<lang>_COMPILER option would be useful to be able to run tests with different compilers.

Nov 30 2017, 3:18 AM
omalyshe added a comment to D40386: [OpenMP] Add entry for Intel Compiler 18.

Question to Intel: At the moment we have to add a new compiler version each year. Can we switch to the same process used for Clang and GCC, i.e. automatically getting the version and composing the string?

Nov 30 2017, 3:08 AM
omalyshe updated the diff for D40309: Extension of HWLOC topology discovery with NUMA nodes and tiles.

Fix for non-hwloc build

Nov 30 2017, 2:27 AM
omalyshe added a comment to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

@omalyshe Which version of icc introduced the ident information for workshare constructs?

ICC with the ident information has not been released yet

In that case cancel/cancel_worksharing.c should fail for icc-17, icc-18 too?

No, the ident information was only missing for the worksharing constructs. For cancellation constructs, the compiler generates a call to '__kmpc_cancel(...)' with the correct kind parameter. icc-16 however did not generate the correct call.

Nov 30 2017, 1:19 AM

Nov 29 2017

omalyshe added a comment to D40384: [OMPT] Add annotations to testcases that are expected to fail when using certain compilers.

@omalyshe Which version of icc introduced the ident information for workshare constructs?

Nov 29 2017, 1:09 AM

Nov 22 2017

omalyshe created D40356: Fix types of Fortran array elements.
Nov 22 2017, 7:13 AM
omalyshe created D40340: Warning is emitted when tiles are requested but cannot be used.
Nov 22 2017, 3:36 AM

Nov 21 2017

omalyshe created D40309: Extension of HWLOC topology discovery with NUMA nodes and tiles.
Nov 21 2017, 7:56 AM
omalyshe created D40296: Fix aligned memory allocation in the stub library .
Nov 21 2017, 4:59 AM

Nov 10 2017

omalyshe added inline comments to D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 7:28 AM
omalyshe added inline comments to D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 6:16 AM
omalyshe added inline comments to D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 6:12 AM
omalyshe added inline comments to D39890: [OMPT] Fix assertion for OpenMP code generated with outdated compilers.
Nov 10 2017, 5:00 AM

Nov 8 2017

omalyshe added inline comments to D39801: [OMPT] Provide initialization for Mac OS X.
Nov 8 2017, 8:09 AM

Oct 31 2017

omalyshe added inline comments to D39439: [OpenMP]Fix race condition in omp_init_lock.
Oct 31 2017, 3:27 AM · Restricted Project

Oct 18 2017

omalyshe added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 18 2017, 1:44 AM

Oct 17 2017

omalyshe added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

LGTM.

Oct 17 2017, 2:43 AM

Oct 4 2017

omalyshe added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 4 2017, 7:14 AM

Oct 3 2017

omalyshe added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 3 2017, 8:43 AM
omalyshe added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 3 2017, 6:29 AM

Sep 29 2017

omalyshe added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Sep 29 2017, 7:06 AM

Aug 2 2017

omalyshe created D36225: Exclude version symbols for static libomp.
Aug 2 2017, 8:50 AM

Jul 18 2017

omalyshe accepted D35535: Fix sporadic segfaults in tasking tests.

LGTM.

Jul 18 2017, 4:46 AM · Restricted Project

Apr 4 2017

omalyshe committed rL299437: Test cancellation_for_sections.c expectedly fails on GCC.
Test cancellation_for_sections.c expectedly fails on GCC
Apr 4 2017, 7:52 AM
omalyshe committed rL299434: Reset cancellation status for 'parallel', 'sections' and 'for' constracts..
Reset cancellation status for 'parallel', 'sections' and 'for' constracts.
Apr 4 2017, 7:09 AM
omalyshe closed D31419: Reset cancellation status for 'parallel', 'sections' and 'for' constracts. by committing rL299434: Reset cancellation status for 'parallel', 'sections' and 'for' constracts..
Apr 4 2017, 7:09 AM
omalyshe committed rL299428: Test check-in, comment changed.
Test check-in, comment changed
Apr 4 2017, 6:09 AM
omalyshe updated the diff for D31419: Reset cancellation status for 'parallel', 'sections' and 'for' constracts..

Added test case for the loop construct with '#pragma omp cancel' followed by the sections construct with cancellation point

Apr 4 2017, 4:50 AM

Mar 28 2017

omalyshe accepted D29638: Fix for bug https://llvm.org/bugs/show_bug.cgi?id=30889.

LGTM.

Mar 28 2017, 6:07 AM
omalyshe created D31419: Reset cancellation status for 'parallel', 'sections' and 'for' constracts..
Mar 28 2017, 5:56 AM

Mar 1 2017

omalyshe added a comment to D30450: OpenMP version 5.0 added.

Do we really need this? In other words: Is there a use case for not building the OpenMP runtime for the latest standard?

Mar 1 2017, 3:13 AM

Feb 28 2017

omalyshe created D30450: OpenMP version 5.0 added.
Feb 28 2017, 2:06 AM

Feb 27 2017

omalyshe created D30408: Mixed type atomic routines are missed from DLL (Windows).
Feb 27 2017, 7:44 AM
omalyshe created D30404: Assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITY.
Feb 27 2017, 6:50 AM

Oct 11 2016

omalyshe updated the diff for D25275: Mixed type atomic routines added for capture and update/capture reverse..

Updated the diff to address Jonathan's comment.

Oct 11 2016, 6:51 AM

Oct 5 2016

omalyshe retitled D25275: Mixed type atomic routines added for capture and update/capture reverse. from to Mixed type atomic routines added for capture and update/capture reverse..
Oct 5 2016, 5:56 AM

Sep 20 2016

omalyshe retitled D24761: Fixed incorrect OpenMP version in Fortran module. from to Fixed incorrect OpenMP version in Fortran module. .
Sep 20 2016, 6:33 AM
omalyshe retitled D24756: Mixed type atomic routines for unsigned integers. from to Mixed type atomic routines for unsigned integers..
Sep 20 2016, 2:48 AM

Aug 29 2016

omalyshe retitled D23990: Use 'critical' reduction method when 'atomic' is not available but requested. from to Use 'critical' reduction method when 'atomic' is not available but requested..
Aug 29 2016, 6:05 AM

May 23 2016

omalyshe updated the diff for D20525: [OMPT] Use more general function for getting gtid.

The full diff attached.

May 23 2016, 9:00 AM
omalyshe retitled D20525: [OMPT] Use more general function for getting gtid from to [OMPT] Use more general function for getting gtid.
May 23 2016, 8:19 AM

Apr 13 2016

omalyshe accepted D19030: [ITTNOTIFY] Correct barrier imbalance time in case of tasks.

LGTM.

Apr 13 2016, 9:02 AM

Mar 24 2016

omalyshe accepted D18348: [OMPT] Fix parallel_id and task_id in loop_end with schedule static.

LGTM.

Mar 24 2016, 5:51 AM
omalyshe accepted D16716: [OMPT] Fix duplicate implicit_task_end events for master thread with GCC.

LGTM.

Mar 24 2016, 5:42 AM

Mar 15 2016

omalyshe accepted D16714: [OMPT] Fix wrong parent_task_id in serialized parallel_begin with GCC.

LGTM.

Mar 15 2016, 1:02 AM

Feb 26 2016

omalyshe added a comment to D16714: [OMPT] Fix wrong parent_task_id in serialized parallel_begin with GCC.

Is it OK that ompt_parallel_id_new() is called several times for one region? First in line 393 and then inside kmp_serialized_parallel() it can be called once or twice.

Feb 26 2016, 6:50 AM

Sep 21 2015

omalyshe added inline comments to D12998: Overhaul OMPT initialization interface.
Sep 21 2015, 1:17 AM

Sep 17 2015

omalyshe accepted D12911: Correct an incorrect OMPT ifdef .

LGTM.

Sep 17 2015, 2:11 AM

Aug 5 2015

omalyshe retitled D11763: Fix CMake build on Windows from to Fix CMake build on Windows .
Aug 5 2015, 8:00 AM

Jul 1 2015

omalyshe accepted D10863: OMPT event_barrier_end fix.

LGTM.

Jul 1 2015, 1:43 AM

Jun 29 2015

omalyshe accepted D10798: Improve OMPT code: remove use of assignment to multiple struct fields using .fieldname .

LGTM.

Jun 29 2015, 6:04 AM

Apr 29 2015

omalyshe added a comment to D8918: Modify runtime to call correct functions for OMPT.

LGTM. Can be committed.

Apr 29 2015, 4:19 AM
omalyshe added inline comments to D8918: Modify runtime to call correct functions for OMPT.
Apr 29 2015, 12:46 AM

Apr 27 2015

omalyshe added a comment to D8916: kmp_lock: Change return type of release functions from void to int.

LGTM. Please, commit.

Apr 27 2015, 3:47 AM
omalyshe added a comment to D8917: Add new files for OMPT.

LGTM. Please, commit.

Apr 27 2015, 3:47 AM

Apr 24 2015

omalyshe added inline comments to D8918: Modify runtime to call correct functions for OMPT.
Apr 24 2015, 9:59 AM

Apr 16 2015

omalyshe added inline comments to D8917: Add new files for OMPT.
Apr 16 2015, 7:28 AM

Apr 10 2015

omalyshe added inline comments to D8917: Add new files for OMPT.
Apr 10 2015, 9:02 AM