This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Allow automatically deducing the thumb instruction size for .inst
ClosedPublic

Authored by mstorsjo on Jul 27 2018, 2:11 PM.

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 27 2018, 2:11 PM

That looks like the right behaviour to me. For reference the Arm ARM definition of Thumb Instruction width from encodeing is in https://developer.arm.com/products/architecture/cpu-architecture/a-profile/docs/ddi0406/latest/arm-architecture-reference-manual-armv7-a-and-armv7-r-edition 6.1 Thumb Instruction set encoding.

test/MC/ARM/inst-thumb-suffixes-auto.s
2

Would be good to add a test with triple armebv7-linux-gnueabi, my understanding is that the .inst and CHECK should remain the same.

mstorsjo added inline comments.Jul 30 2018, 3:58 AM
test/MC/ARM/inst-thumb-suffixes-auto.s
2

Yes, these ones remain the same here since it just tests the output assembly, not the generated binary. I'll amend the test.

mstorsjo updated this revision to Diff 157937.Jul 30 2018, 3:58 AM

Added a test RUN line with a big-endian arch.

compnerd accepted this revision.Jul 30 2018, 1:12 PM
This revision is now accepted and ready to land.Jul 30 2018, 1:12 PM
This revision was automatically updated to reflect the committed changes.