Page MenuHomePhabricator

[test-suite] Add pathfinder kernel from Rodinia Benchmark
ClosedPublic

Authored by proton on Jul 26 2018, 4:26 PM.

Details

Summary

Runtime:

OptimizationKernelProgram
-O00.9136501.415s
-O30.081188s0.341s
-O3 -polly0.033881s0.300s

Diff Detail

Event Timeline

proton created this revision.Jul 26 2018, 4:26 PM
proton updated this revision to Diff 157906.Jul 29 2018, 6:46 PM
proton retitled this revision from [test-suite] Added pathfinder kernel from Rodinia Benchmark to [test-suite] Add pathfinder kernel from Rodinia Benchmark.
proton edited the summary of this revision. (Show Details)

Changes:
removed typedef int matrix[row][col]
compare the hash of output instead of checking all values

Can you add the Rodinia/Makefile file? It was present in the first revision r338163 but after it was reverted in r338166, the subsequent revisions didn't add it back and it's been causing buildbot failures ever since.

Can you add the Rodinia/Makefile file? It was present in the first revision r338163 but after it was reverted in r338166, the subsequent revisions didn't add it back and it's been causing buildbot failures ever since.

@homerdin took care of it. The Makefile template does not seem to be prepared to include a file from another directory (../Common/glibc_compat_rand.c), so we opted to exclude the benchmark from the Makefile build.

Ok, thank you.

MatzeB added inline comments.Aug 2 2018, 4:49 PM
MultiSource/Benchmarks/Rodinia/pathfinder/CMakeLists.txt
2–7

Note: I am currently cleaning up the test-suite cmake code a bit. This needs to be changed to:

llvm_multisource(pathfinder main.c pathfinderKernel.c ../Common/glibc_compat_rand.c)

(with the set(PROG and set(Source lines removed)
before committing.

5

You can also drop the set(WORKDIR line if the benchmark isn't reading any files and doesn't care what directory it is running in.

proton updated this revision to Diff 158964.Aug 3 2018, 3:22 AM

changed CMakeLists.txt

This revision is now accepted and ready to land.Aug 3 2018, 9:15 AM
This revision was automatically updated to reflect the committed changes.