proton (Pankaj)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2018, 10:30 AM (23 w, 2 d)

Recent Activity

Sep 14 2018

proton added inline comments to D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Sep 14 2018, 1:31 PM

Aug 31 2018

proton accepted D51048: cmake: Specify reference outputs in llvm_test_data().

I don't understand this. llvm_test_verify_hash_program_output() only inserts a hashing step to the verification script, you still need the final fpcmp invocation (and the WORKDIR setting is separate for every step).

In the definition of llvm_test_verify_hash_program_output(), llvm_test_verify(WORKDIR ${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${_file}) is called which sets the work directory to current binary directory. So we need not call llvm_test_verify with WORKDIR ${CMAKE_CURRENT_BINARY_DIR} argument after llvm_test_verify_hash_program_output, simply llvm_test_verify(${FPCMP} bilinear.reference_output bilinearOutput.txt) will work. Passing WORKDIR argument does not cause any harm though.

Aug 31 2018, 4:05 AM

Aug 30 2018

proton added a comment to D51048: cmake: Specify reference outputs in llvm_test_data().

After applying this patch, the tests fail for me because it is taking the hash of stdout instead of the file mentioned in llvm_test_verify_hash_program_output macro.
Changing line 64 of cmake/modules/SingleMultiSource.cmake to ${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${file} will fix this.

Aug 30 2018, 11:42 AM

Aug 17 2018

proton committed rL340002: Add BilateralFiltering kernel using Benchmark Library.
Add BilateralFiltering kernel using Benchmark Library
Aug 17 2018, 2:15 AM
proton committed rT340002: Add BilateralFiltering kernel using Benchmark Library.
Add BilateralFiltering kernel using Benchmark Library
Aug 17 2018, 2:15 AM
proton closed D50529: [test-suite] Add Bilateral Filter kernel using benchmark library.
Aug 17 2018, 2:15 AM

Aug 13 2018

proton committed rL339565: Removed std=c++11 flag from MicroBenchmarks/ImageProcessing/Dilate/CMakeLists..
Removed std=c++11 flag from MicroBenchmarks/ImageProcessing/Dilate/CMakeLists.
Aug 13 2018, 6:57 AM
proton committed rT339565: Removed std=c++11 flag from MicroBenchmarks/ImageProcessing/Dilate/CMakeLists..
Removed std=c++11 flag from MicroBenchmarks/ImageProcessing/Dilate/CMakeLists.
Aug 13 2018, 6:57 AM
proton committed rT339564: Add Image dilate kernel(for grayscale Images) using Benchmark Library.
Add Image dilate kernel(for grayscale Images) using Benchmark Library
Aug 13 2018, 6:52 AM
proton committed rL339564: Add Image dilate kernel(for grayscale Images) using Benchmark Library.
Add Image dilate kernel(for grayscale Images) using Benchmark Library
Aug 13 2018, 6:45 AM
proton closed D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.
Aug 13 2018, 6:45 AM

Aug 9 2018

proton updated the diff for D50529: [test-suite] Add Bilateral Filter kernel using benchmark library.

Reduced test size
Total runtime is still there for about 5.5s (with benchmark library) because the benchmark library runs kernel for multiple inputs.

Aug 9 2018, 4:25 PM
proton created D50529: [test-suite] Add Bilateral Filter kernel using benchmark library.
Aug 9 2018, 12:53 PM

Aug 8 2018

proton committed rT339228: Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt.
Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
Aug 8 2018, 2:56 AM
proton committed rL339228: Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt.
Removed -std=c++11 flag from MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
Aug 8 2018, 2:56 AM
proton closed D50425: The fix for c++11 flag issue was fixed in svn r339154 but for one Blur benchmark..
Aug 8 2018, 2:56 AM
proton accepted D50425: The fix for c++11 flag issue was fixed in svn r339154 but for one Blur benchmark..
Aug 8 2018, 2:49 AM

Aug 7 2018

proton added a comment to D50379: New ImageProcessing tests were failing becuase c++ flags are used in c flags..

Thank you for the solution Santosh, It seems like my GitHub account was actually linked to some other account on Phabricator which I was not aware of, so I didn't get any notification for this patch on this account. I will try to get that account removed so that this won't happen in future.

Aug 7 2018, 1:02 PM
proton committed rL339154: Fixed build error caused by MicroBenchmarks/ImageProcessing with clang.
Fixed build error caused by MicroBenchmarks/ImageProcessing with clang
Aug 7 2018, 10:22 AM
proton committed rT339154: Fixed build error caused by MicroBenchmarks/ImageProcessing with clang.
Fixed build error caused by MicroBenchmarks/ImageProcessing with clang
Aug 7 2018, 10:21 AM
proton committed rT339115: Add interpolation kernels using Benchmark Library.
Add interpolation kernels using Benchmark Library
Aug 7 2018, 1:53 AM
proton committed rL339115: Add interpolation kernels using Benchmark Library.
Add interpolation kernels using Benchmark Library
Aug 7 2018, 1:53 AM
proton closed D50345: [test-suite] Add Interpolation kernels Using Benchmark Library.
Aug 7 2018, 1:53 AM

Aug 6 2018

proton committed rT339055: Add image blur algorithms using Benchmark Library.
Add image blur algorithms using Benchmark Library
Aug 6 2018, 2:16 PM
proton committed rL339055: Add image blur algorithms using Benchmark Library.
Add image blur algorithms using Benchmark Library
Aug 6 2018, 2:16 PM
proton closed D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Aug 6 2018, 2:16 PM
proton closed D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Aug 6 2018, 2:16 PM
proton committed rT339052: Add backprop kernel from Rodinia benchmark.
Add backprop kernel from Rodinia benchmark
Aug 6 2018, 1:41 PM
proton committed rL339052: Add backprop kernel from Rodinia benchmark.
Add backprop kernel from Rodinia benchmark
Aug 6 2018, 1:41 PM
proton closed D48046: [test-suite] Backprop kernel from Rodinia Benchmark.
Aug 6 2018, 1:40 PM
proton updated the diff for D48046: [test-suite] Backprop kernel from Rodinia Benchmark.

made changes requested by @Meinersbur

Aug 6 2018, 1:32 PM
proton created D50345: [test-suite] Add Interpolation kernels Using Benchmark Library.
Aug 6 2018, 12:13 PM
proton abandoned D49246: Added Image Processing Kernels Using Benchmark Library.

Adding each kernel in separate patches so that it will be easy to review and also we can revert only that kernel which causes problems (if any).

Aug 6 2018, 6:15 AM
proton committed rT339010: Add Anisotropic diffusion using Benchmark Library.
Add Anisotropic diffusion using Benchmark Library
Aug 6 2018, 5:51 AM
proton committed rL339010: Add Anisotropic diffusion using Benchmark Library.
Add Anisotropic diffusion using Benchmark Library
Aug 6 2018, 5:51 AM
proton closed D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion.
Aug 6 2018, 5:51 AM
proton committed rT339006: Add Image dithering kernels using Benchmark Library.
Add Image dithering kernels using Benchmark Library
Aug 6 2018, 4:19 AM
proton committed rL339006: Add Image dithering kernels using Benchmark Library.
Add Image dithering kernels using Benchmark Library
Aug 6 2018, 4:19 AM
proton closed D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Aug 6 2018, 4:19 AM
proton committed rT339004: Add utilities functions for Image Processing Kernels.
Add utilities functions for Image Processing Kernels
Aug 6 2018, 4:01 AM
proton committed rL339004: Add utilities functions for Image Processing Kernels.
Add utilities functions for Image Processing Kernels
Aug 6 2018, 3:58 AM
proton closed D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Aug 6 2018, 3:58 AM

Aug 4 2018

proton updated the diff for D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Aug 4 2018, 7:36 AM

Aug 3 2018

proton committed rL338924: [test-suite] Add pathfinder kernel from Rodinia Benchmark.
[test-suite] Add pathfinder kernel from Rodinia Benchmark
Aug 3 2018, 2:39 PM
proton committed rT338924: [test-suite] Add pathfinder kernel from Rodinia Benchmark.
[test-suite] Add pathfinder kernel from Rodinia Benchmark
Aug 3 2018, 2:38 PM
proton closed D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark.
Aug 3 2018, 2:38 PM
proton committed rL338922: Test commit.
Test commit
Aug 3 2018, 2:03 PM
proton committed rT338922: Test commit.
Test commit
Aug 3 2018, 2:03 PM
proton updated the diff for D48046: [test-suite] Backprop kernel from Rodinia Benchmark.

Changes:

  • Use glibc_compat_rand.c from Common folder of Rodinia
  • Use float * instead of the pointer to VLA in main.c
  • Changed CMakeLists.txt
Aug 3 2018, 4:42 AM
proton updated the diff for D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark.

changed CMakeLists.txt

Aug 3 2018, 3:22 AM

Jul 29 2018

proton updated the diff for D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark.

Changes:
removed typedef int matrix[row][col]
compare the hash of output instead of checking all values

Jul 29 2018, 6:46 PM

Jul 28 2018

proton updated the diff for D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.

reverted back to int *arr from int (*arr)[][].

Jul 28 2018, 7:09 AM
proton updated the diff for D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.

added some comments

Jul 28 2018, 7:07 AM
proton updated the diff for D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion.
Jul 28 2018, 4:38 AM

Jul 27 2018

proton updated the summary of D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion.
Jul 27 2018, 4:31 PM
proton added a dependent revision for D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions: D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion.
Jul 27 2018, 4:25 PM
proton added a dependency for D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion: D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Jul 27 2018, 4:25 PM
proton created D49948: [test-suite] Add Image Processing Kernels Using Benchmark Library: Anisotropic diffusion.
Jul 27 2018, 4:24 PM
proton updated the diff for D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.

changed array type from int (*) [][] to int * in main.cpp

Jul 27 2018, 3:40 PM
proton updated the diff for D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.

Changes: update m along with image size when called with the benchmark library. For verification, only m=4 is used.

Jul 27 2018, 2:50 PM
proton added inline comments to D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Jul 27 2018, 2:48 PM
proton updated the diff for D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.

Changes: Used C99 VLAs in kernels.

Jul 27 2018, 2:01 PM
proton updated the diff for D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.

Renamed glibc_compat_rand.cpp back to glibc_compat_rand.c and fixed the link erorr mentioned earlier in summary (when glibc_compat_rand.c was used) .

Jul 27 2018, 12:40 PM
proton updated the diff for D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.
Jul 27 2018, 11:46 AM
proton updated the diff for D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.

made changes requested by @Meinersbur

Jul 27 2018, 11:45 AM

Jul 26 2018

proton added a dependency for D49894: [test-suite] Added hotspot kernel from Rodinia Benchmark: D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark.
Jul 26 2018, 5:50 PM
proton added a dependent revision for D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark: D49894: [test-suite] Added hotspot kernel from Rodinia Benchmark.
Jul 26 2018, 5:50 PM
proton added a dependency for D49891: [test-suite] Added srad kernel from Rodinia Benchmark: D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark.
Jul 26 2018, 5:47 PM
proton added a dependent revision for D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark: D49891: [test-suite] Added srad kernel from Rodinia Benchmark.
Jul 26 2018, 5:47 PM
proton added a dependent revision for D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark: D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark.
Jul 26 2018, 5:47 PM
proton added a dependency for D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark: D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark.
Jul 26 2018, 5:47 PM
proton created D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark.
Jul 26 2018, 5:46 PM
proton created D49894: [test-suite] Added hotspot kernel from Rodinia Benchmark.
Jul 26 2018, 5:42 PM
proton updated the summary of D49891: [test-suite] Added srad kernel from Rodinia Benchmark.
Jul 26 2018, 5:17 PM
proton created D49891: [test-suite] Added srad kernel from Rodinia Benchmark.
Jul 26 2018, 5:16 PM
proton created D49886: [test-suite] Add pathfinder kernel from Rodinia Benchmark.
Jul 26 2018, 4:26 PM
proton added inline comments to D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.
Jul 26 2018, 3:48 PM
proton added a dependent revision for D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions: D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.
Jul 26 2018, 3:39 PM
proton added a dependency for D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel: D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Jul 26 2018, 3:39 PM
proton created D49883: [test-suite] Added Image Processing Kernels Using Benchmark Library: Dilate Kernel.
Jul 26 2018, 3:39 PM
proton updated the diff for D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Jul 26 2018, 3:30 PM

Jul 21 2018

proton updated the diff for D48046: [test-suite] Backprop kernel from Rodinia Benchmark.

The kernel runs for 0.79 sec and the complete program runs for 0.81 sec.

Jul 21 2018, 7:00 AM

Jul 20 2018

proton updated the diff for D48046: [test-suite] Backprop kernel from Rodinia Benchmark.

It runs for 1.1 sec for normal problem size and 0.6 sec for smaller
The main kernel function takes around 0.7-0.8 sec of 1.1 sec.
Polly detects scops here but runtime is still same

Jul 20 2018, 9:01 AM

Jul 18 2018

proton created D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Jul 18 2018, 12:24 PM

Jul 16 2018

proton added inline comments to D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Jul 16 2018, 2:16 PM
proton updated the diff for D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.

Changed function parameters from "int image[HEIGHT][WIDTH]" to "int *image"

Jul 16 2018, 2:10 PM
proton updated the diff for D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Jul 16 2018, 2:06 PM
proton updated the summary of D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Jul 16 2018, 12:58 PM
proton added a comment to D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.

I'm not sure why these utilities are being added, is there some other patch that will be using this?

Yes. They are added as a separate patch and this patch will be mentioned if they are using this.

Jul 16 2018, 12:56 PM

Jul 14 2018

proton created D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms.
Jul 14 2018, 12:43 AM
proton created D49339: [test-suite] Added Image Processing Kernels Using Benchmark Library: utilities functions.
Jul 14 2018, 12:04 AM

Jul 12 2018

proton created D49246: Added Image Processing Kernels Using Benchmark Library.
Jul 12 2018, 9:00 AM

Jun 25 2018

proton updated the diff for D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

added LICENSE and fixed work directory issue.

Jun 25 2018, 10:50 PM

Jun 21 2018

proton updated the diff for D48046: [test-suite] Backprop kernel from Rodinia Benchmark.

Added -ffast-math flag... Polly recognizes entire kernel but still no performance improvement with Polly.

Jun 21 2018, 2:34 PM
proton added a comment to D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

Thanks for making some of the changes. I'm still not clear on a couple of things.

Do you mind sharing some of the results with the new benchmark runs, with the different image sizes? Do we actually get the throughput numbers in there as well?

Jun 21 2018, 1:16 PM
proton updated the diff for D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

Formatted using clang format

Jun 21 2018, 1:14 PM

Jun 20 2018

proton updated the diff for D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.
Jun 20 2018, 6:36 PM

Jun 18 2018

proton updated the diff for D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

Runtime on this differential

Jun 18 2018, 4:11 PM

Jun 13 2018

proton added a comment to D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

Could you check whether llvm-lit correctly collects execution time, compile/link time, LLVM -stats, code size?

I don't know how to check LLVM -stats using lit.
Sizes matches the output of llvm-size, compile time and link time are also fine.

Jun 13 2018, 6:22 PM
proton updated the diff for D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.

Updated input size, used malloc to allocate memory for the array.

Jun 13 2018, 5:51 PM