This is an archive of the discontinued LLVM Phabricator instance.

Differential D49618

[clang-tidy] remove private decltypeType in TrailingReturnType
ClosedPublic

Authored by JonasToth on Jul 20 2018, 2:53 PM.

Details

Reviewers
aaron.ballman
alexfh
hokein
Commits
rGe8217f6a1f26: [clang-tidy] remove private decltypeType in TrailingReturnType
rCTE337707: [clang-tidy] remove private decltypeType in TrailingReturnType
rL337707: [clang-tidy] remove private decltypeType in TrailingReturnType
Summary

This patch removes a private matcher in fuchsia/TrailingReturnType check because
the matcher is now in ASTMatchers

Diff Detail

Event Timeline

JonasToth created this revision.Jul 20 2018, 2:53 PM
Herald added subscribers: cfe-commits, xazax.hun. · View Herald TranscriptJul 20 2018, 2:53 PM
Harbormaster completed remote builds in B20568: Diff 156615.Jul 20 2018, 2:53 PM
JonasToth added a parent revision: D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType.Jul 20 2018, 2:53 PM
aaron.ballman accepted this revision.Jul 23 2018, 5:17 AM

LGTM!

This revision is now accepted and ready to land.Jul 23 2018, 5:17 AM
JonasToth updated this revision to Diff 156805.Jul 23 2018, 9:27 AM
  • rebase to master
Harbormaster completed remote builds in B20608: Diff 156805.Jul 23 2018, 9:27 AM
Closed by commit rL337707: [clang-tidy] remove private decltypeType in TrailingReturnType (authored by JonasToth). · Explain WhyJul 23 2018, 9:30 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 23 2018, 9:30 AM

Revision Contents

PathSize
clang-tidy/
fuchsia/
2 lines

Diff 156805

clang-tidy/fuchsia/TrailingReturnCheck.cpp

Show All 13 Lines
using namespace clang::ast_matchers; using namespace clang::ast_matchers;
namespace clang { namespace clang {
namespace tidy { namespace tidy {
namespace fuchsia { namespace fuchsia {
namespace { namespace {
const internal::VariadicDynCastAllOfMatcher<Type, DecltypeType> decltypeType;
AST_MATCHER(FunctionDecl, hasTrailingReturn) { AST_MATCHER(FunctionDecl, hasTrailingReturn) {
return Node.getType()->castAs<FunctionProtoType>()->hasTrailingReturn(); return Node.getType()->castAs<FunctionProtoType>()->hasTrailingReturn();
} }
} // namespace } // namespace
void TrailingReturnCheck::registerMatchers(MatchFinder *Finder) { void TrailingReturnCheck::registerMatchers(MatchFinder *Finder) {
// Requires C++11 or later. // Requires C++11 or later.
Show All 23 Lines