This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Allow running ABI list tests with different ABI versions
ClosedPublic

Authored by ldionne on Jul 18 2018, 2:21 PM.

Details

Summary

Currently, the ABI list test only works for ABI version 1. This commit
allows running the ABI list test with ABI version 2. It also adds an
ABI list file for ABI v2 on Mac OS X.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Jul 18 2018, 2:21 PM

This went out to llvm-commits. You may wanna re-upload with cfe-commits added instead.

ldionne edited subscribers, added: cfe-commits; removed: llvm-commits.Jul 19 2018, 7:22 AM

This went out to llvm-commits. You may wanna re-upload with cfe-commits added instead.

Ah! That uncovers a deeper problem -- the instructions when setting up the monorepo with Arcanist say to copy .arcconfig from llvm/. This is wrong, as I guess it depends what component you will be submitting to.

This went out to llvm-commits. You may wanna re-upload with cfe-commits added instead.

Ah! That uncovers a deeper problem -- the instructions when setting up the monorepo with Arcanist say to copy .arcconfig from llvm/. This is wrong, as I guess it depends what component you will be submitting to.

Nope, actually, that's not it. It's this Herald rule kicking in:

EricWF accepted this revision.Jul 19 2018, 11:02 AM

LGTM. Though it might be worth noting that we don't really have an "ABI v2" yet; we're just staging it ATM.

This revision is now accepted and ready to land.Jul 19 2018, 11:02 AM
This revision was automatically updated to reflect the committed changes.
libcxx/trunk/lib/abi/x86_64-apple-darwin.v2.abilist