This is an archive of the discontinued LLVM Phabricator instance.

Differential D49394

Add R_HEX_B15_PCREL relocation
ClosedPublic

Authored by sidneym on Jul 16 2018, 11:54 AM.

Details

Reviewers
ruiu
kparzysz
shankare
• espindola
Commits
rG690b544f41d2: [ELF][HEXAGON] Add support for R_HEX_B15_PCREL
rL337494: [ELF][HEXAGON] Add support for R_HEX_B15_PCREL
rLLD337494: [ELF][HEXAGON] Add support for R_HEX_B15_PCREL
Summary

Add B15_PCREL relocation support and test, presumes that https://reviews.llvm.org/D48235 has merged.

Diff Detail

Event Timeline

sidneym created this revision.Jul 16 2018, 11:54 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJul 16 2018, 11:54 AM
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. · View Herald Transcript
ruiu accepted this revision.Jul 18 2018, 10:50 AM

LGTM with these fixes.

ELF/Arch/Hexagon.cpp
56–59

Sort alphabetically.

81

Sort cases alphabetically.

This revision is now accepted and ready to land.Jul 18 2018, 10:50 AM
sidneym updated this revision to Diff 156346.Jul 19 2018, 1:03 PM

Update to sort relocs.

Closed by commit rLLD337494: [ELF][HEXAGON] Add support for R_HEX_B15_PCREL (authored by sidneym). · Explain WhyJul 19 2018, 1:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
ELF/
Arch/
4 lines
test/
ELF/
4 lines

Diff 156346

ELF/Arch/Hexagon.cpp

Context not available.
RelExpr Hexagon::getRelExpr(RelType Type, const Symbol &S, RelExpr Hexagon::getRelExpr(RelType Type, const Symbol &S,
const uint8_t *Loc) const { const uint8_t *Loc) const {
switch (Type) { switch (Type) {
case R_HEX_B15_PCREL:
case R_HEX_B22_PCREL: case R_HEX_B22_PCREL:
case R_HEX_B22_PCREL_X: case R_HEX_B22_PCREL_X:
case R_HEX_B32_PCREL_X: case R_HEX_B32_PCREL_X:
ruiuUnsubmitted
Not Done
ReplyInline Actions

Sort alphabetically.

ruiu: Sort alphabetically.
Context not available.
switch (Type) { switch (Type) {
case R_HEX_NONE: case R_HEX_NONE:
break; break;
case R_HEX_B15_PCREL:
or32le(Loc, applyMask(0x00df20fe, Val >> 2));
break;
case R_HEX_B22_PCREL: case R_HEX_B22_PCREL:
or32le(Loc, applyMask(0x1ff3ffe, Val >> 2)); or32le(Loc, applyMask(0x1ff3ffe, Val >> 2));
break; break;
Context not available.
ruiuUnsubmitted
Not Done
ReplyInline Actions

Sort cases alphabetically.

ruiu: Sort `case`s alphabetically.

test/ELF/hexagon.s

Context not available.
# RUN: ld.lld %t2 %t -o %t3 # RUN: ld.lld %t2 %t -o %t3
# RUN: llvm-objdump -d %t3 | FileCheck %s # RUN: llvm-objdump -d %t3 | FileCheck %s
# R_HEX_B15_PCREL
if (p0) jump:nt #_start
# CHECK: if (p0) jump:nt 0x11000
# R_HEX_B22_PCREL # R_HEX_B22_PCREL
call #_start call #_start
# CHECK: call 0x11000 # CHECK: call 0x11000
Context not available.