Page MenuHomePhabricator

shankare (Shankar Easwaran)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 8:50 PM (204 w, 6 h)

Recent Activity

Aug 21 2018

shankare accepted D50603: Add R_HEX_16_X relocation.
Aug 21 2018, 8:49 AM

May 10 2018

shankare accepted D46728: Update Hexagon's relocation output.
May 10 2018, 3:22 PM

Apr 10 2017

shankare accepted D31831: posix_fallocate isn't support on all filesystems.
Apr 10 2017, 6:34 PM

Mar 31 2017

shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..

Updated patch with reverting the previous change.

Mar 31 2017, 11:46 AM
shankare added a comment to D31500: [ARM]Add a NOP instruction to make LLVM generate a mapping symbol.

Can you please merge the change ?

Mar 31 2017, 4:34 AM

Mar 30 2017

shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

https://reviews.llvm.org/D31500

Mar 30 2017, 9:26 AM
shankare created D31500: [ARM]Add a NOP instruction to make LLVM generate a mapping symbol.
Mar 30 2017, 9:26 AM

Mar 29 2017

shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Thanks Peter, I will revise the lld test and recommit the change.

Mar 29 2017, 7:07 PM

Mar 28 2017

shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..

Check for section permissions to account for test cases that rely on the behavior.

Mar 28 2017, 9:57 AM
shankare reopened D30724: Dont emit Mapping symbols for sections that contain only data..

The changes are causing a problem as tests in lld have been written with the assumption that objdump will be able to dump data inside of a text section. I am hence uploading a new patch that checks for section permissions as well. Please let me know how you want to go about it ?

Mar 28 2017, 9:21 AM

Mar 27 2017

shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Thanks Tim for the detailed review.

Mar 27 2017, 8:03 PM

Mar 22 2017

shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 22 2017, 1:20 PM
shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..

Address comments from Tim. I will make the AArch64 changes as a separate commit.

Mar 22 2017, 12:57 PM

Mar 21 2017

shankare added inline comments to D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 21 2017, 10:28 AM
shankare added inline comments to D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 21 2017, 10:18 AM

Mar 14 2017

shankare added inline comments to D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 14 2017, 2:48 PM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Does AARCH64 use Mapping symbols anytime ? I havent seen GCC doing that.

Mar 14 2017, 2:33 PM
shankare added inline comments to D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 14 2017, 2:31 PM

Mar 13 2017

shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Ping ?

Mar 13 2017, 8:56 AM

Mar 8 2017

shankare added a reviewer for D30724: Dont emit Mapping symbols for sections that contain only data.: t.p.northover.
Mar 8 2017, 6:03 PM
shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..

Update with comments from Tim and address the issue that he mentioned.

Mar 8 2017, 5:24 PM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

I was discussing with Colin L and found a way to handle your case. Will post a patch soon.

Mar 8 2017, 10:17 AM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Though, The testcase that you have mentioned is a genuine test and GCC supports it!.

Mar 8 2017, 9:28 AM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

I see what you are saying.

Mar 8 2017, 9:03 AM
shankare added inline comments to D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 8 2017, 8:33 AM
shankare updated the diff for D30724: Dont emit Mapping symbols for sections that contain only data..

Updated with review comments from Tim.

Mar 8 2017, 7:40 AM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

It looks like gcc doesnot purely go by whether section has data or not. It also checks for section permissions.

Mar 8 2017, 5:15 AM

Mar 7 2017

shankare added a comment to D19982: FileOutputBuffer : Fix undefined behavior on windows.

I totally forgot about your comment, I will respond to you with a testcase shortly.

Mar 7 2017, 7:15 PM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

Ah ok. Thanks for the info. If the input is 'C', the extent to which a non allocatable section that can contain data and code mixed is really a corner case, unless the author does inline assembly ?

Mar 7 2017, 7:13 PM
shankare added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

When I checked with GCC (Using tests) the behavior seems to be non allocatable sections do not have mapping symbols.

Mar 7 2017, 5:59 PM
shankare created D30724: Dont emit Mapping symbols for sections that contain only data..
Mar 7 2017, 4:26 PM

May 9 2016

shankare added a comment to D19982: FileOutputBuffer : Fix undefined behavior on windows.

I was trying to debug a problem with the usage of FileOutputBuffer where the memory contents are not being synced to disk. I traced every call in FileOutputBuffer and none of the calls return an error, but the file is not synced. This happens on windows systems with FAST IO enabled. Resizing the underlying file makes the problem disappear.

May 9 2016, 3:16 PM

May 5 2016

shankare retitled D19982: FileOutputBuffer : Fix undefined behavior on windows from to FileOutputBuffer : Fix undefined behavior on windows.
May 5 2016, 9:25 AM

Mar 24 2016

shankare added a reviewer for D15965: Add support for dumping relocations in non-relocatable files: shankare.
r_offset
This member gives the location at which to apply the relocation action. For a relocatable file, the value is the byte offset from the beginning of the section to the storage unit affected by the relocation. For an executable file or a shared object, the value is the virtual address of the storage unit affected by the relocation.
Mar 24 2016, 12:35 PM

Mar 17 2016

shankare added a comment to D15965: Add support for dumping relocations in non-relocatable files.

r_offset is being modeled as per the ELF spec IMO and looks correct. GNU objdump does show relocations when there are relocation sections, that point to the section that needs relocation.

Mar 17 2016, 2:21 PM

Oct 26 2015

shankare added a comment to D14034: [ELF2] Implement --start-group,--end-group.

How are symbols resolved when there are multiple --start-group and --end-group options currently ? Which symbol is picked when there is a unresolved symbol from the second group ?

Oct 26 2015, 12:56 PM · lld

Oct 23 2015

shankare added a comment to D14034: [ELF2] Implement --start-group,--end-group.

I am trying to say without --start-group and --end-group, the linker would have produced an unresolved symbol.

Oct 23 2015, 7:16 PM · lld
shankare added a comment to D14034: [ELF2] Implement --start-group,--end-group.

Thanks Ruiu, Bigcheese. It would become confusing for the user when migrating from the GNU linker.

Oct 23 2015, 6:58 PM · lld
shankare retitled D14034: [ELF2] Implement --start-group,--end-group from to [ELF2] Implement --start-group,--end-group.
Oct 23 2015, 5:25 PM · lld

Oct 16 2015

shankare added inline comments to D13814: Add support for SHF_MERGE sections.
Oct 16 2015, 12:27 PM · lld

Sep 28 2015

shankare added a comment to D13196: ELF] Remove merge strings functionality..

Any other comments ?, If not I will go ahead and commit this change and continue getting the Atom model for ELF

Sep 28 2015, 5:18 PM · lld

Sep 26 2015

shankare retitled D13196: ELF] Remove merge strings functionality. from to ELF] Remove merge strings functionality..
Sep 26 2015, 4:20 PM · lld

Sep 24 2015

shankare accepted D13148: ELF2: Support reponse files..

Thanks for the info, LGTM.

Sep 24 2015, 9:04 PM
shankare added inline comments to D13153: [ELF2] Use static non-member function when it suffices.
Sep 24 2015, 8:55 PM
shankare added inline comments to D13148: ELF2: Support reponse files..
Sep 24 2015, 8:54 PM