[test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms

[proton]

Summary

Added mean filter blur and gaussian blur using benchmark library

Apply D49339 before applying this as D49339 contains some helper functions used here.

[dberris]

MicroBenchmarks/ImageProcessing/Blur/blur.h

15–18 ↗

(On Diff #155554)

Do these functions need the array sizes at all? Why not just use int **?

MicroBenchmarks/ImageProcessing/Blur/main.cpp

167 ↗

(On Diff #155554)

You probably want a ::benchmark::DoNotOptimize(...) around this and other calls to the kernel.

[proton]

Changed function parameters from "int image[HEIGHT][WIDTH]" to "int *image"

[proton]

MicroBenchmarks/ImageProcessing/Blur/main.cpp

167 ↗

(On Diff #155554)

I don't think I can use "::benchmark::DoNotOptimize(...)" here as the functions return void and DoNotOptimize forces the compiler to flush pending writes to memory.

[Meinersbur]

MicroBenchmarks/ImageProcessing/Blur/main.cpp

156–157 ↗

(On Diff #155760)

[nit] empty lines

175–177 ↗

(On Diff #155760)

@dberris Would ::benchmark::ClobberMemory() be a viable alternative?

[dberris]

MicroBenchmarks/ImageProcessing/Blur/main.cpp

175–177 ↗

(On Diff #155760)

It may be.

[Meinersbur]

MicroBenchmarks/ImageProcessing/Blur/boxBlurKernel.cpp

10–11 ↗

(On Diff #155760)

Can you change inpImage/outImage to use C99 array parameter syntax?

MicroBenchmarks/ImageProcessing/Blur/main.cpp

175–177 ↗

(On Diff #155760)

I suggest to leave it as is for the moment. If we found a canonical approach, we can change this and the other benchmarks afterwards.

Could you add a comment that this is supposed keep the compiler to optimize the computation away?

[Meinersbur]

LGTM

MicroBenchmarks/ImageProcessing/Blur/main.cpp

175–177 ↗

(On Diff #155760)

@proton Please don't forget to add a comment about that this code is meant to inhibit too-aggressive compiler optimizations.

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt

+set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
+
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+
+llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt")
+llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/boxBlur.reference_output")
+
+llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt")
+llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/gaussianBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/gaussianBlur.reference_output")
+
+llvm_test_run(WORKDIR ${CMAKE_CURRENT_BINARY_DIR})
+
+llvm_test_executable(blur ../utils/ImageHelper.cpp ../utils/glibc_compat_rand.c main.cpp boxBlurKernel.c gaussianBlurKernel.c)
+
+target_link_libraries(blur benchmark)

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/blur.h

+/**
+Pankaj Kukreja
+github.com/proton0001
+Indian Institute of Technology Hyderabad
+*/
+
+#ifndef _BOX_BLUR_H
+#define _BOX_BLUR_H
+
+#define HEIGHT 1024
+#define WIDTH 1024
+
+#define BOX_SIZE 9
+
+#endif /* _BOX_BLUR_H */

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/boxBlur.reference_output

+d976614a6d0487da6873eb9de4044480

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/boxBlurKernel.c

+/**
+Blur an Image using box blur
+
+Pankaj Kukreja
+Indian Institute of Technology Hyderabad
+*/
+
+#include "blur.h"
+void boxBlurKernel(int height, int width, int inputImage[HEIGHT][WIDTH],
+                   int outputImage[height][width]) {
+  int sum = 0;
+  int offset = (BOX_SIZE - 1) / 2;
+  int n = BOX_SIZE * BOX_SIZE;
+
+  for (int i = offset; i < height - offset; i++) {
+    for (int j = offset; j < width - offset; j++) {
+      sum = 0;
+      for (int k = -1 * offset; k < offset; k++) {
+        for (int l = -1 * offset; l < offset; l++) {
+          sum += inputImage[i + k][j + l];
+        }
+      }
+      outputImage[i][j] = (sum) / (n);
+    }
+  }
+}
 No newline at end of file

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/gaussianBlur.reference_output

+7f4246596bcfbb5e6e44cd21ddfeaf07

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/gaussianBlurKernel.c

+/**
+Gaussian Blur Kernel
+
+Pankaj Kukreja
+github.com/proton0001
+Indian Institute of Technology Hyderabad
+*/
+
+#include "blur.h"
+#include <math.h> // For M_PI and exp
+
+void gaussianBlurKernel(int height, int width, int inputImage[height][width],
+                        int outputImage[height][width]) {
+
+  float sigma = 9;
+  float s = 2.0 * sigma * sigma;
+  int offset = (BOX_SIZE - 1) / 2;
+
+  float sum = 0;
+  float gaussianFilter[BOX_SIZE][BOX_SIZE] = {0};
+
+  for (int x = -1 * offset; x <= offset; x++) {
+    for (int y = -1 * offset; y <= offset; y++) {
+      gaussianFilter[x + offset][y + offset] =
+          (exp(-(x * x + y * y) / s)) / (M_PI * s);
+      sum += gaussianFilter[x + offset][y + offset];
+    }
+  }
+
+  float sum_in_current_frame = 0;
+  for (int i = offset; i < height - offset; i++) {
+    for (int j = offset; j < width - offset; j++) {
+      /* Computing sum of (elements * corresponding gaussianFilter) in window
+       * centered at i,j */
+      sum_in_current_frame = 0;
+      for (int k = -1 * offset; k <= offset; k++) {
+        for (int l = -1 * offset; l <= offset; l++) {
+          sum_in_current_frame += (inputImage[i + k][j + l] *
+                                   gaussianFilter[k + offset][l + offset]);
+        }
+      }
+      outputImage[i][j] = (sum_in_current_frame) / sum;
+    }
+  }
+}

test-suite/trunk/MicroBenchmarks/ImageProcessing/Blur/main.cpp

+/**
+Pankaj Kukreja
+github.com/proton0001
+Indian Institute of Technology Hyderabad
+*/
+
+#include "ImageHelper.h"
+#include "blur.h"
+#include <iostream>
+
+#define BENCHMARK_LIB
+#ifdef BENCHMARK_LIB
+#include "benchmark/benchmark.h"
+#endif
+extern "C" void boxBlurKernel(int height, int width, int *inpImage,
+                              int *outpImage);
+extern "C" void gaussianBlurKernel(int height, int width, int *inpImage,
+                                   int *outpImage);
+int *inputImage;
+int main(int argc, char *argv[]) {
+
+#ifdef BENCHMARK_LIB
+  ::benchmark::Initialize(&argc, argv);
+#endif
+
+  const char *boxBlurOutputFileName = (const char *)"./boxBlurOutput.txt";
+  const char *gaussianBlurOutputFileName =
+      (const char *)"./gaussianBlurOutput.txt";
+
+  inputImage = (int *)malloc(sizeof(int) * (HEIGHT) * (WIDTH));
+
+  if (inputImage == NULL) {
+    std::cerr << "Insufficient memory\n";
+    exit(1);
+  }
+
+  initializeRandomImage(inputImage, HEIGHT, WIDTH);
+
+// Run Kernels Using Benchmark Library
+#ifdef BENCHMARK_LIB
+  ::benchmark::RunSpecifiedBenchmarks();
+#endif
+
+  // Run Kernels once more and save output in a file for Verification
+  int *outputImage;
+  outputImage = (int *)malloc(sizeof(int) * (HEIGHT) * (WIDTH));
+
+  if (outputImage == NULL) {
+    std::cerr << "Insufficient memory\n";
+    exit(1);
+  }
+
+  boxBlurKernel(HEIGHT, WIDTH, inputImage, outputImage);
+
+  // Blur not applied on edges so we add a black border
+  // Otherwise we may get garbage value which may create problem in output
+  // verification
+
+  int offset = (BOX_SIZE - 1) / 2;
+  // Top Edge
+  for (int i = 0; i < offset; i++) {
+    for (int j = 0; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  // Bottom Edge
+  for (int i = HEIGHT - offset; i < HEIGHT; i++) {
+    for (int j = 0; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  // Left Edge
+  for (int i = 0; i < HEIGHT; i++) {
+    for (int j = 0; j < offset; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+  // Right Edge
+  for (int i = 0; i < HEIGHT; i++) {
+    for (int j = WIDTH - offset; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  saveImage(outputImage, boxBlurOutputFileName, HEIGHT, WIDTH);
+
+  gaussianBlurKernel(HEIGHT, WIDTH, inputImage, outputImage);
+
+  // Top Edge
+  for (int i = 0; i < offset; i++) {
+    for (int j = 0; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  // Bottom Edge
+  for (int i = HEIGHT - offset; i < HEIGHT; i++) {
+    for (int j = 0; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  // Left Edge
+  for (int i = 0; i < HEIGHT; i++) {
+    for (int j = 0; j < offset; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+  // Right Edge
+  for (int i = 0; i < HEIGHT; i++) {
+    for (int j = WIDTH - offset; j < WIDTH; j++) {
+      outputImage[i * WIDTH + j] = 0;
+    }
+  }
+
+  saveImage(outputImage, gaussianBlurOutputFileName, HEIGHT, WIDTH);
+
+  free(outputImage);
+  free(inputImage);
+  return EXIT_SUCCESS;
+}
+
+#ifdef BENCHMARK_LIB
+void BENCHMARK_boxBlurKernel(benchmark::State &state) {
+
+  int height = state.range(0);
+  int width = state.range(1);
+
+  int *outputImage = (int *)malloc(sizeof(int) * (height) * (width));
+
+  if (outputImage == NULL) {
+    std::cerr << "Insufficient memory\n";
+    exit(1);
+  }
+  /* This call is to warm up the cache */
+  boxBlurKernel(height, width, inputImage, outputImage);
+
+  for (auto _ : state) {
+    boxBlurKernel(height, width, inputImage, outputImage);
+  }
+  /* Since we are not passing state.range as 20 this if case will always be
+   * false. This if case is to prevent above kernel calls from getting optimized
+   * out */
+  if (state.range(0) == 20) {
+    saveImage(outputImage, (const char *)"testFailed.txt", height, width);
+  }
+
+  free(outputImage);
+}
+BENCHMARK(BENCHMARK_boxBlurKernel)
+    ->Args({128, 128})
+    ->Args({256, 256})
+    ->Args({512, 512})
+    ->Args({1024, 1024})
+    ->Unit(benchmark::kMicrosecond);
+
+void BENCHMARK_GAUSSIAN_BLUR(benchmark::State &state) {
+
+  int height = state.range(0);
+  int width = state.range(1);
+
+  int *outputImage = (int *)malloc(sizeof(int) * (height) * (width));
+
+  if (outputImage == NULL) {
+    std::cerr << "Insufficient memory\n";
+    exit(1);
+  }
+  /* This call is to warm up the cache */
+  gaussianBlurKernel(height, width, inputImage, outputImage);
+
+  for (auto _ : state) {
+    gaussianBlurKernel(height, width, inputImage, outputImage);
+  }
+  /* Since we are not passing state.range as 20 this if case will always be
+   * false. This if case is to prevent above kernel calls from getting optimized
+   * out */
+  if (state.range(0) == 20) {
+    saveImage(outputImage, (const char *)"testFailed.txt", height, width);
+  }
+
+  free(outputImage);
+}
+
+BENCHMARK(BENCHMARK_GAUSSIAN_BLUR)
+    ->Args({128, 128})
+    ->Args({256, 256})
+    ->Args({512, 512})
+    ->Args({1024, 1024})
+    ->Unit(benchmark::kMicrosecond);
+#endif

test-suite/trunk/MicroBenchmarks/ImageProcessing/CMakeLists.txt

 add_subdirectory(Dither)
 add_subdirectory(AnisotropicDiffusion)
+add_subdirectory(Blur)