Page MenuHomePhabricator

[analyzer] pr38072: Suppress an assertion failure for eliding the same destructor twice due to the default argument problem.
ClosedPublic

Authored by NoQ on Jul 11 2018, 6:30 PM.

Details

Summary

@alexfh provided an example that demonstrates that elided copy constructors may get agglutinated due to improper control flow when default arguments are involved.

Suppress the assertion failure for now. Proper support is still an open problem.

Diff Detail

Repository
rC Clang

Event Timeline

NoQ created this revision.Jul 11 2018, 6:30 PM
NoQ added inline comments.
lib/StaticAnalyzer/Core/ExprEngine.cpp
434–435

Same problem here.

LGTM with a nit.

test/Analysis/temporaries.cpp
472

// no-crash?

This revision is now accepted and ready to land.Jul 17 2018, 11:32 AM
This revision was automatically updated to reflect the committed changes.