Page MenuHomePhabricator

[AArch64] Remove AArch64TargetLowering::BuildSDIVPow2 override
AbandonedPublic

Authored by RKSimon on Jul 11 2018, 4:14 AM.

Details

Summary

Now that D45806 etc has landed we've greatly improved the generic SDIV by constant handling in DAGCombiner.

While investigating how to support non-uniform vectors for TargetLowering::BuildSDIV (PR36545) it was noticed that removing the AArch64 override and using the generic path appears to improve codegen, but I'd like confirmation from arm specialists.

Diff Detail

Repository
rL LLVM

Event Timeline

RKSimon created this revision.Jul 11 2018, 4:14 AM

The codegen was changed intentionally; see https://reviews.llvm.org/D4438 .

The codegen was changed intentionally; see https://reviews.llvm.org/D4438 .

So should I abandon this?

Yes, unless you have some evidence the previous benchmarking was wrong.

RKSimon abandoned this revision.Jul 11 2018, 12:12 PM

llvm-mca says something similar - abandoning