This is an archive of the discontinued LLVM Phabricator instance.

[clangd] ClangdServer::codeComplete return CodeCompleteResult, not LSP struct.
ClosedPublic

Authored by sammccall on Jul 2 2018, 1:53 AM.

Details

Summary

This provides more structured information that embedders can use for rendering.
ClangdLSPServer continues to call render(), so NFC.

The patch is:

  • trivial changes to ClangdServer/ClangdLSPServer
  • mostly-mechanical updates to CodeCompleteTests etc for the new API
  • new direct tests of render() in CodeCompleteTests
  • tiny cleanups to CodeCompletionItem (operator<< and missing initializers)

Event Timeline

sammccall created this revision.Jul 2 2018, 1:53 AM
ioeric accepted this revision.Jul 2 2018, 2:57 AM

lgtm

This revision is now accepted and ready to land.Jul 2 2018, 2:57 AM
This revision was automatically updated to reflect the committed changes.