This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Customizable URI schemes for dynamic index.
ClosedPublic

Authored by ioeric on Jun 8 2018, 12:57 AM.

Details

Summary

This allows dynamic index to have consistent URI schemes with the
static index which can have customized URI schemes, which would make file
proximity scoring based on URIs easier.

Event Timeline

ioeric created this revision.Jun 8 2018, 12:57 AM

Not ignoring this patch: the implementation LG, whether it's the right design depends on where D47935 ends up I think.
(I suspect this is what we want, is there any urgency to landing this part?)

sammccall accepted this revision.Jun 15 2018, 1:38 AM
sammccall added inline comments.
unittests/clangd/FileIndexTests.cpp
99

This can use the shared unittest: scheme from the followup patch, right?

Add a fixme or lift that into this patch?

This revision is now accepted and ready to land.Jun 15 2018, 1:38 AM
ioeric updated this revision to Diff 151467.Jun 15 2018, 1:56 AM
ioeric marked an inline comment as done.
  • Pulled unittest URI refactoring from D47935
This revision was automatically updated to reflect the committed changes.
ioeric added inline comments.Jun 15 2018, 2:00 AM
unittests/clangd/FileIndexTests.cpp
99

Done. Lifted the TestFS change into this patch.