This adds support to option -plugin-opt=dwo_dir=${DIR}. This option is used to specify the directory to store the .dwo files when LTO and debug fission is used
at the same time.
Details
Details
Diff Detail
Diff Detail
- Repository
- rLLD LLVM Linker
Event Timeline
ELF/Options.td | ||
---|---|---|
445 | sort |
test/ELF/lto/thinlto-debug-fission.ll | ||
---|---|---|
3 ↗ | (On Diff #155198) | Remove. |
4 ↗ | (On Diff #155198) | Double space characters. |
7 ↗ | (On Diff #155198) | If the specified directory doesn't exist, does --plug-opt=dwo_dir creates a new directory? |
7 ↗ | (On Diff #155198) | -o /dev/null is preferred if you don't need an output file. |
test/ELF/lto/thinlto-debug-fission.ll | ||
---|---|---|
7 ↗ | (On Diff #155198) | Yes, it will create a new directory if the specified directory does not exist. |
Comment Actions
LGTM
test/ELF/lto/thinlto-debug-fission.ll | ||
---|---|---|
7 ↗ | (On Diff #155198) | I'd add an rm -rf %T/dwo to test that and make sure that files aren't left over from previous runs. |
test/ELF/lto/thinlto-debug-fission.ll | ||
---|---|---|
7 ↗ | (On Diff #155198) | Move the rm -rf before the call to ld.lld. |
test/ELF/lto/thinlto-debug-fission.ll | ||
---|---|---|
7 ↗ | (On Diff #155198) |
Looks like this wasn't resolved before committing. |
The new option should appear before this line I think.