Page MenuHomePhabricator

yunlian (Yunlian Jiang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2015, 10:33 AM (220 w, 10 h)

Recent Activity

Sep 26 2018

yunlian added a reviewer for D52524: Add -Wpoison-system-directories warning: manojgupta.
Sep 26 2018, 10:55 AM · Restricted Project

Sep 25 2018

yunlian added reviewers for D52524: Add -Wpoison-system-directories warning: ddunbar, thakis, espindola.
Sep 25 2018, 4:09 PM · Restricted Project
yunlian created D52524: Add -Wpoison-system-directories warning.
Sep 25 2018, 4:04 PM · Restricted Project

Jul 16 2018

yunlian committed rL337210: remove temporal file directory before testing in thinlto-debug-fission.ll.
remove temporal file directory before testing in thinlto-debug-fission.ll
Jul 16 2018, 1:34 PM
yunlian committed rLLD337210: remove temporal file directory before testing in thinlto-debug-fission.ll.
remove temporal file directory before testing in thinlto-debug-fission.ll
Jul 16 2018, 1:34 PM
yunlian closed D49390: remove temporal file directory before testing in thinlto-debug-fission.ll.
Jul 16 2018, 1:33 PM
yunlian set the repository for D49390: remove temporal file directory before testing in thinlto-debug-fission.ll to rLLD LLVM Linker.
Jul 16 2018, 1:33 PM
yunlian updated the diff for D49390: remove temporal file directory before testing in thinlto-debug-fission.ll.
Jul 16 2018, 1:24 PM
yunlian planned changes to D49390: remove temporal file directory before testing in thinlto-debug-fission.ll.
Jul 16 2018, 11:32 AM
yunlian retitled D49390: remove temporal file directory before testing in thinlto-debug-fission.ll from remove temporal file directory before testing to remove temporal file directory before testing in thinlto-debug-fission.ll.
Jul 16 2018, 11:32 AM
yunlian created D49390: remove temporal file directory before testing in thinlto-debug-fission.ll.
Jul 16 2018, 11:31 AM
yunlian added a comment to D47904: Support option -plugin-opt=dwo_dir=.

I added the 'rm' after the test. Will upload another patch to fix that.

Jul 16 2018, 11:23 AM
yunlian committed rL337195: Support option -plugin-opt=dwo_dir=.
Support option -plugin-opt=dwo_dir=
Jul 16 2018, 11:01 AM
yunlian committed rLLD337195: Support option -plugin-opt=dwo_dir=.
Support option -plugin-opt=dwo_dir=
Jul 16 2018, 11:01 AM
yunlian closed D47904: Support option -plugin-opt=dwo_dir=.
Jul 16 2018, 11:00 AM
yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.

removed temporary file generated by the test.

Jul 16 2018, 10:54 AM
yunlian added a comment to D47904: Support option -plugin-opt=dwo_dir=.

ping?

Jul 16 2018, 9:34 AM

Jul 12 2018

yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.
Jul 12 2018, 10:08 AM
yunlian added inline comments to D47904: Support option -plugin-opt=dwo_dir=.
Jul 12 2018, 10:07 AM
yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.

unittest added

Jul 12 2018, 9:34 AM

Jul 11 2018

yunlian added a comment to D47904: Support option -plugin-opt=dwo_dir=.

I will upload a test later.

Jul 11 2018, 9:59 AM
yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.
Jul 11 2018, 9:58 AM

Jun 28 2018

yunlian added a reviewer for D48247: lld: add experimental support for SHT_RELR sections.: yunlian.
Jun 28 2018, 1:49 PM
yunlian added a reviewer for D47919: llvm-readobj: add experimental support for SHT_RELR sections.: yunlian.
Jun 28 2018, 10:57 AM

Jun 27 2018

yunlian added reviewers for D48680: Add missing visibility annotation for __base: pcc, mclow.lists.
Jun 27 2018, 4:21 PM
yunlian created D48680: Add missing visibility annotation for __base.
Jun 27 2018, 4:19 PM

Jun 26 2018

yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.

Upload the right patch, fixed the option order in Options.td

Jun 26 2018, 10:17 AM

Jun 25 2018

yunlian committed rC335546: Add an option to support debug fission on implicit ThinLTO..
Add an option to support debug fission on implicit ThinLTO.
Jun 25 2018, 4:10 PM
yunlian committed rL335546: Add an option to support debug fission on implicit ThinLTO..
Add an option to support debug fission on implicit ThinLTO.
Jun 25 2018, 4:10 PM
yunlian closed D44788: Add an option to support debug fission on implicit ThinLTO..
Jun 25 2018, 4:10 PM
yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..
Jun 25 2018, 3:47 PM
yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Jun 25 2018, 3:18 PM

Jun 20 2018

yunlian updated the diff for D47904: Support option -plugin-opt=dwo_dir=.
Jun 20 2018, 1:34 PM
yunlian added a comment to D47904: Support option -plugin-opt=dwo_dir=.

ping?

Jun 20 2018, 11:26 AM
yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..

Removed redundant 'if' statement

Jun 20 2018, 11:25 AM
yunlian added inline comments to D44788: Add an option to support debug fission on implicit ThinLTO..
Jun 20 2018, 9:58 AM

Jun 14 2018

yunlian added a comment to D47904: Support option -plugin-opt=dwo_dir=.

ping?

Jun 14 2018, 10:34 AM
yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Jun 14 2018, 10:34 AM

Jun 8 2018

yunlian added a reviewer for D47904: Support option -plugin-opt=dwo_dir=: pcc.
Jun 8 2018, 10:10 AM
yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Jun 8 2018, 10:09 AM

Jun 7 2018

yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..

Makes the default value to /path/to/binary_dwo, when DWO_DIR is provided, make the path to DWO_DIR/path/to/binary_dwo

Jun 7 2018, 3:36 PM
yunlian created D47904: Support option -plugin-opt=dwo_dir=.
Jun 7 2018, 1:24 PM

Jun 5 2018

yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..
Jun 5 2018, 12:48 PM
yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Jun 5 2018, 10:34 AM

May 14 2018

yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..

Use the option -gsplit-dwarf to make it more consistent.

May 14 2018, 3:03 PM

May 3 2018

yunlian updated the diff for D46137: Fix an assertion of This DIE should've already been constructed when the " "definition DIE was created in " "getOrCreateSubprogramDIE.

It looks like this error comes from the mixing of LTO, debug fission and -fdebug-info-for-profiling.

May 3 2018, 8:55 AM

Apr 30 2018

yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Apr 30 2018, 9:59 AM

Apr 26 2018

yunlian created D46137: Fix an assertion of This DIE should've already been constructed when the " "definition DIE was created in " "getOrCreateSubprogramDIE.
Apr 26 2018, 11:00 AM

Apr 18 2018

yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

ping?

Apr 18 2018, 9:10 AM

Apr 13 2018

yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

I prefer to have a dedicated directory to store all the .dwo files. As dblaikie said, all the .dwo files are temporary files. In addition, in order to differentiate the .dwo files generated by different link stage with the same .o, we need to add
some suffixes to the .dwo file. So for a file a.o, we may need to generate a .dwo named a._${number}_${random_string}.dwo, which is not neat. Furthermore, we need to dealing with archive files. In this case, we may need to generate
multiple .dwo files for a single archive files.

Apr 13 2018, 1:51 PM

Apr 12 2018

yunlian committed rL329988: Enable debug fission for thinLTO linked via gold-plugin.
Enable debug fission for thinLTO linked via gold-plugin
Apr 12 2018, 10:08 PM
yunlian closed D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 12 2018, 10:08 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.

Fix an indent error during rebase.

Apr 12 2018, 8:52 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.

rebase to trunk.

Apr 12 2018, 8:42 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 12 2018, 4:21 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 12 2018, 9:20 AM

Apr 10 2018

yunlian added inline comments to D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 10 2018, 10:15 AM

Apr 9 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 9 2018, 9:37 AM

Apr 4 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 4 2018, 11:02 AM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 4 2018, 10:17 AM
yunlian added inline comments to D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 4 2018, 9:46 AM

Apr 3 2018

yunlian added inline comments to D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 3 2018, 4:11 PM
yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..
Apr 3 2018, 1:50 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Apr 3 2018, 1:39 PM
yunlian added a comment to D44792: Enable debug fission for thinLTO linked via gold-plugin.

You shouldn't need clang to test ThinLTO. See for example any of the tests in test/tools/gold/X86/thinlto*.ll.

Thanks, It seems I can to pass -shared to gold to avoid invoking clang. A test case was uploaded.

Apr 3 2018, 8:42 AM

Mar 29 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 29 2018, 9:11 AM

Mar 28 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 28 2018, 3:29 PM
yunlian added a comment to D44792: Enable debug fission for thinLTO linked via gold-plugin.
In D44792#1047010, @pcc wrote:

A reminder to add context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Test cases please. Also I think you will need to add the dwo path and the task id to the cache key if split dwarf is enabled.

Mar 28 2018, 9:26 AM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 28 2018, 9:23 AM

Mar 27 2018

yunlian updated the diff for D44788: Add an option to support debug fission on implicit ThinLTO..
Mar 27 2018, 10:26 AM

Mar 26 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 26 2018, 4:31 PM

Mar 23 2018

yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 23 2018, 4:31 PM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 23 2018, 4:20 PM
yunlian added inline comments to D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 23 2018, 10:23 AM
yunlian updated the diff for D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 23 2018, 10:18 AM

Mar 22 2018

yunlian added inline comments to D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 22 2018, 11:41 AM
yunlian added a comment to D44788: Add an option to support debug fission on implicit ThinLTO..

I have another one D44792 on LLVM side.

Mar 22 2018, 10:42 AM
yunlian created D44792: Enable debug fission for thinLTO linked via gold-plugin.
Mar 22 2018, 10:29 AM
yunlian created D44788: Add an option to support debug fission on implicit ThinLTO..
Mar 22 2018, 9:43 AM

Jul 11 2017

yunlian added a comment to D35081: [ThinLTO] Allow multiple summary entries..

I've sent a reproduce test case to tejohnson.

Jul 11 2017, 2:32 PM
yunlian added a comment to D35081: [ThinLTO] Allow multiple summary entries..

This error happens when I try to triage a thinLTO failure on ARM.

Jul 11 2017, 11:06 AM

Dec 3 2015

yunlian added a comment to D14480: Improve running time of getAsmSrcLocInfo.

A test case with 4K lines of code can show the difference. Reducing the compilation time from 3 seconds to instant on my desktop. Do you need that?
Could you please commit this for me? I still do not have the right to commit yet.

Dec 3 2015, 4:49 PM · Restricted Project

Nov 30 2015

yunlian added a comment to D14480: Improve running time of getAsmSrcLocInfo.

ping?

Nov 30 2015, 1:23 PM · Restricted Project

Nov 23 2015

yunlian added a comment to D14480: Improve running time of getAsmSrcLocInfo.

ping?

Nov 23 2015, 9:18 AM · Restricted Project

Nov 17 2015

yunlian updated the diff for D14480: Improve running time of getAsmSrcLocInfo.

Applied Rafael's patch while still looking to see what is wrong of my git clang format.

Nov 17 2015, 9:01 AM · Restricted Project

Nov 16 2015

yunlian added inline comments to D14480: Improve running time of getAsmSrcLocInfo.
Nov 16 2015, 4:34 PM · Restricted Project
yunlian added inline comments to D14480: Improve running time of getAsmSrcLocInfo.
Nov 16 2015, 4:26 PM · Restricted Project
yunlian updated the diff for D14480: Improve running time of getAsmSrcLocInfo.

I did not realize that git clang-format will modify the code directly. Updated.
Thanks

Nov 16 2015, 2:55 PM · Restricted Project
yunlian added a comment to D14480: Improve running time of getAsmSrcLocInfo.

ping?

Nov 16 2015, 9:03 AM · Restricted Project

Nov 11 2015

yunlian updated the diff for D14480: Improve running time of getAsmSrcLocInfo.

The clang-format check is done. The doc comment is updated.

Nov 11 2015, 10:51 AM · Restricted Project

Nov 9 2015

yunlian added a comment to D14480: Improve running time of getAsmSrcLocInfo.

Is there an example for the test case with timeout? Thanks

Nov 9 2015, 10:17 AM · Restricted Project

Nov 7 2015

yunlian added a reviewer for D14480: Improve running time of getAsmSrcLocInfo: rafael.
Nov 7 2015, 7:31 AM · Restricted Project

Nov 6 2015

yunlian updated the diff for D14480: Improve running time of getAsmSrcLocInfo.

Some format changes.

Nov 6 2015, 11:53 PM · Restricted Project
yunlian retitled D14480: Improve running time of getAsmSrcLocInfo from to Improve running time of getAsmSrcLocInfo.
Nov 6 2015, 11:36 PM · Restricted Project

Sep 9 2015

yunlian added a comment to D10279: Handle '-r' option properly.

ping?

Sep 9 2015, 11:10 AM

Aug 31 2015

yunlian updated the diff for D10279: Handle '-r' option properly.

I uploaded a test case.
Without the patch, the test case fails, with the patch, the test case passes.

Aug 31 2015, 4:59 PM
yunlian added a comment to D10279: Handle '-r' option properly.

Do you still have the test case?

Aug 31 2015, 10:10 AM

Jul 20 2015

yunlian added a comment to D10279: Handle '-r' option properly.

What is your test case?
I followed the bug https://llvm.org/bugs/show_bug.cgi?id=12587

Jul 20 2015, 11:57 AM

Jul 17 2015

yunlian added a comment to D10279: Handle '-r' option properly.

It seems this have not been checked in, could you please double check that?

Jul 17 2015, 11:31 AM

Jul 14 2015

yunlian added a comment to D10279: Handle '-r' option properly.

I have done arc commit --revision D<Revision> in my local svn repository and it seems to be successful, did I miss some thing?
If it does not get committed, please commit it for me, thanks.

Jul 14 2015, 1:17 PM