This is an archive of the discontinued LLVM Phabricator instance.

Differential D47850

[Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
ClosedPublic

Authored by smeenai on Jun 6 2018, 3:54 PM.

Details

Reviewers
compnerd
mstorsjo
rnk
Commits
rG09edbddee749: [Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
rC334145: [Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
rL334145: [Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
Summary

-fseh-exceptions is only meaningful for MinGW targets, and that driver
already has logic to pass either -fdwarf-exceptiosn or -fseh-exceptions
as appropriate. -fseh-exceptions is just a no-op for MSVC triples, and
passing it to cc1 causes unnecessary confusion.

Diff Detail

Event Timeline

smeenai created this revision.Jun 6 2018, 3:54 PM
Herald added subscribers: JDevlieghere, aprantl. · View Herald TranscriptJun 6 2018, 3:54 PM
Harbormaster completed remote builds in B19015: Diff 150212.Jun 6 2018, 3:54 PM
rnk accepted this revision.Jun 6 2018, 4:03 PM

lgtm

This revision is now accepted and ready to land.Jun 6 2018, 4:03 PM
Closed by commit rL334145: [Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc (authored by smeenai). · Explain WhyJun 6 2018, 4:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJun 6 2018, 4:13 PM

Revision Contents

PathSize
lib/
Driver/
2 lines
test/
Driver/
9 lines

Diff 150212

lib/Driver/ToolChain.cpp

Show First 20 Lines • Show All 465 Lines • ▼ Show 20 Lines
ObjCRuntime ToolChain::getDefaultObjCRuntime(bool isNonFragile) const { ObjCRuntime ToolChain::getDefaultObjCRuntime(bool isNonFragile) const {
return ObjCRuntime(isNonFragile ? ObjCRuntime::GNUstep : ObjCRuntime::GCC, return ObjCRuntime(isNonFragile ? ObjCRuntime::GNUstep : ObjCRuntime::GCC,
VersionTuple()); VersionTuple());
} }
llvm::ExceptionHandling llvm::ExceptionHandling
ToolChain::GetExceptionModel(const llvm::opt::ArgList &Args) const { ToolChain::GetExceptionModel(const llvm::opt::ArgList &Args) const {
if (Triple.isOSWindows() && Triple.getArch() != llvm::Triple::x86)
return llvm::ExceptionHandling::WinEH;
return llvm::ExceptionHandling::None; return llvm::ExceptionHandling::None;
} }
bool ToolChain::isThreadModelSupported(const StringRef Model) const { bool ToolChain::isThreadModelSupported(const StringRef Model) const {
if (Model == "single") { if (Model == "single") {
// FIXME: 'single' is only supported on ARM and WebAssembly so far. // FIXME: 'single' is only supported on ARM and WebAssembly so far.
return Triple.getArch() == llvm::Triple::arm || return Triple.getArch() == llvm::Triple::arm ||
Triple.getArch() == llvm::Triple::armeb || Triple.getArch() == llvm::Triple::armeb ||
▲ Show 20 Lines • Show All 452 Lines • Show Last 20 Lines

test/Driver/windows-exceptions.cpp

  • This file was added.
// RUN: %clang -target i686-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s
// RUN: %clang -target x86_64-windows-msvc -c %s -### 2>&1 | FileCheck -check-prefix=MSVC %s
// RUN: %clang -target i686-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-DWARF %s
// RUN: %clang -target x86_64-windows-gnu -c %s -### 2>&1 | FileCheck -check-prefix=MINGW-SEH %s
MSVC-NOT: -fdwarf-exceptions
MSVC-NOT: -fseh-exceptions
MINGW-DWARF: -fdwarf-exceptions
MINGW-SEH: -fseh-exceptions