This is an archive of the discontinued LLVM Phabricator instance.

[HWASan] Report proper error on allocator failures instead of CHECK(0)-ing
ClosedPublic

Authored by alekseyshl on Jun 5 2018, 2:20 PM.

Details

Summary

Currently many allocator specific errors (OOM, for example) are reported as
a text message and CHECK(0) termination, not stack, no details, not too
helpful nor informative. To improve the situation, detailed and
structured errors were defined and reported under the appropriate conditions.

Event Timeline

alekseyshl created this revision.Jun 5 2018, 2:20 PM
Herald added subscribers: Restricted Project, delcypher, kubamracek. · View Herald TranscriptJun 5 2018, 2:20 PM
kcc added a subscriber: kcc.Jun 5 2018, 6:48 PM

are tests possible here?

  • Add allocator tests
In D47798#1123142, @kcc wrote:

are tests possible here?

Well, I was going to add them later as HWAsan tests proven to be finicky, but since you mentioned it, here they are.

Matt, please make the first pass.

LGTM

Matt, please accept it too

morehouse accepted this revision.Jun 7 2018, 11:05 AM

Sure, it just sounded like Kostya wanted someone else to look at it too.

This revision is now accepted and ready to land.Jun 7 2018, 11:05 AM
kcc accepted this revision.Jun 7 2018, 2:26 PM

LGTM

This revision was automatically updated to reflect the committed changes.