This is an archive of the discontinued LLVM Phabricator instance.

MC: Introduce an ELF dwo object writer and teach llvm-mc about it.
ClosedPublic

Authored by pcc on May 17 2018, 8:38 PM.

Event Timeline

pcc created this revision.May 17 2018, 8:38 PM
echristo accepted this revision.May 20 2018, 9:40 PM

And it even comes with testcases. :)

LGTM.

-eric

llvm/lib/MC/ELFObjectWriter.cpp
165

It feels a little awkward to special case this for dwo files rather than just be a general object emitter. That said, generalization should be possible in the future.

This revision is now accepted and ready to land.May 20 2018, 9:40 PM
pcc added inline comments.May 21 2018, 12:43 PM
llvm/lib/MC/ELFObjectWriter.cpp
165

That's true, but right now it feels premature to be generalizing this code, as there aren't enough users yet. Probably something to think about if/when we add another user.

This revision was automatically updated to reflect the committed changes.