This is an archive of the discontinued LLVM Phabricator instance.

Differential D46906

[clangd] Fix a link failure in unittests
ClosedPublic

Authored by aheejin on May 15 2018, 3:14 PM.

Details

Reviewers
sammccall
ioeric
Commits
rG85e38ee18e5c: [clangd] Fix a link failure in unittests
rCTE332438: [clangd] Fix a link failure in unittests
rL332438: [clangd] Fix a link failure in unittests
Summary

D46524 (rL332378) introduced a link failure when built with -DSHARED_LIB=ON, which this patch fixes.

Diff Detail

Event Timeline

aheejin created this revision.May 15 2018, 3:14 PM
Herald added subscribers: cfe-commits, jkorous, MaskRay and 4 others. · View Herald TranscriptMay 15 2018, 3:14 PM
aheejin edited the summary of this revision. (Show Details)May 15 2018, 3:15 PM
Harbormaster completed remote builds in B18148: Diff 146931.May 15 2018, 3:16 PM
ioeric accepted this revision.May 16 2018, 1:40 AM

lgtm

This revision is now accepted and ready to land.May 16 2018, 1:40 AM
Closed by commit rL332438: [clangd] Fix a link failure in unittests (authored by aheejin). · Explain WhyMay 16 2018, 1:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 16 2018, 1:57 AM

Revision Contents

PathSize
unittests/
clangd/
1 line

Diff 146931

unittests/clangd/CMakeLists.txt

Show All 32 Linesadd_extra_unittest(ClangdTests
TraceTests.cpp TraceTests.cpp
TUSchedulerTests.cpp TUSchedulerTests.cpp
URITests.cpp URITests.cpp
XRefsTests.cpp XRefsTests.cpp
) )
target_link_libraries(ClangdTests target_link_libraries(ClangdTests
PRIVATE PRIVATE
clangAST
clangBasic clangBasic
clangDaemon clangDaemon
clangFormat clangFormat
clangFrontend clangFrontend
clangIndex clangIndex
clangLex clangLex
clangSema clangSema
clangTooling clangTooling
clangToolingCore clangToolingCore
LLVMSupport LLVMSupport
LLVMTestingSupport LLVMTestingSupport
) )