This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Make plist-html multi-file.
ClosedPublic

Authored by NoQ on May 15 2018, 1:19 PM.

Details

Summary

Plist diagnostics support multi-file reports since forever. HTML diagnostics support multi-file reports since D30406/rC309968.

plist-html is the diagnostic output mode that produces both html and plist files. It's mostly useful for testing the analyzer itself because plist output is helpful for comparing results produced by different versions of the analyzer via the utils/analyzer/CmpRuns.py and html output allows you to immediately have a look at the changed reports.

Previously plist-html output produced multi-file HTML reports but only single-file Plist reports.

Change plist-html output to produce multi-file Plist reports as well.

I don't think we should care about backwards compatibility here because not only the old mode made no sense but also it doesn't make sense to use plist-html in any user-facing UI anyway.

Diff Detail

Event Timeline

NoQ created this revision.May 15 2018, 1:19 PM
NoQ added inline comments.May 15 2018, 1:21 PM
test/Analysis/diagnostics/plist-multi-file.c
202

Yay we have regular expressions.
() are needed so that not to confuse }}} with }}}.

george.karpenkov accepted this revision.May 15 2018, 5:09 PM

LGTM! with stable-filename option we could even avoid the regexp.

This revision is now accepted and ready to land.May 15 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.