Page MenuHomePhabricator

Allow copy elision in path concatenation
ClosedPublic

Authored by xbolva00 on May 8 2018, 11:28 AM.

Diff Detail

Repository
rCXX libc++

Event Timeline

xbolva00 created this revision.May 8 2018, 11:28 AM
xbolva00 updated this revision to Diff 145740.May 8 2018, 11:29 AM
xbolva00 updated this revision to Diff 145742.May 8 2018, 11:34 AM
xbolva00 updated this revision to Diff 145745.May 8 2018, 11:39 AM

Can anybody give me advice from where to generate patch? I do it from libcxx.

Generating the patch from libc++ is fine (and this patch looks like it has sane paths).

Generating the patch from libc++ is fine (and this patch looks like it has sane paths).

Thank you

EricWF accepted this revision.May 9 2018, 11:38 AM
This revision is now accepted and ready to land.May 9 2018, 11:38 AM
This revision was automatically updated to reflect the committed changes.

Sorry folks, but you can't just take patches to libstdc++ and apply them to libc++.

These libraries have different licenses, and so the author of the patch (Jonathan Wakely in this case) need's to *explicitly* contribute that patch to libc++ under libc++'s license. (Or potentially an employer who owns the rights to it.)

So this needs to be reverted, or Jonathan needs to hop on this thread and very explicitly give permission to relicense this and contribute it to LLVM. Generally, I would strongly encourage the original authors making contributions as it simplifies everything.

@chandlerc thanks for catching this.

As the original author I agree to contribute this patch to libc++ under the terms of the MIT and the University of Illinois licences, and under the terms of "Apache 2 with LLVM exception" if necessary in future.

This permission applies only to this patch, not any other code from GCC.

@chandlerc thanks for catching this.

As the original author I agree to contribute this patch to libc++ under the terms of the MIT and the University of Illinois licences, and under the terms of "Apache 2 with LLVM exception" if necessary in future.

This permission applies only to this patch, not any other code from GCC.

Thanks so much for the fast response! And yeah, let's try to follow a more obvious process in the future. =D