Page MenuHomePhabricator

jwakely (Jonathan Wakely)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2017, 3:27 PM (191 w, 2 d)

Recent Activity

Yesterday

jwakely added inline comments to D68364: Implement C++20's P0784 (More constexpr containers).
Tue, Sep 22, 6:19 AM · Restricted Project, Restricted Project
jwakely added inline comments to D68364: Implement C++20's P0784 (More constexpr containers).
Tue, Sep 22, 6:17 AM · Restricted Project, Restricted Project
jwakely added inline comments to D68364: Implement C++20's P0784 (More constexpr containers).
Tue, Sep 22, 6:15 AM · Restricted Project, Restricted Project

Aug 11 2020

jwakely added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.
In D84049#2182370, @jfb wrote:

We can ping @jwakely for libstdc++ 😃

Aug 11 2020, 2:20 PM · Restricted Project, Restricted Project

Jun 17 2020

jwakely added inline comments to D81348: [compiler-rt][builtins] Add tests for atomic builtins support functions.
Jun 17 2020, 12:24 PM · Restricted Project

Jun 15 2020

jwakely resigned from D81846: [libc++] Allow specifying custom Lit config files.

I don't think this impacts anything I do with lit (which isn't very much anyway).

Jun 15 2020, 4:35 PM · Restricted Project

Apr 14 2020

jwakely added a comment to D78154: [WIP][libc++] Link c++experimental.a into libc++.dylib when enabled.

@jwakely , how does libstdc++ ship experimental features? Does it ship them in its shared library?

Apr 14 2020, 4:20 PM · Restricted Project

Feb 27 2020

jwakely added a comment to D75199: Build fix: Turn off _GLIBCXX_DEBUG on gcc 9.

P.S. you could use _GLIBCXX_ASSERTIONS instead for affected versions of libstdc++. That is a subset of _GLIBCXX_DEBUG that has far fewer checks, but is still much better than not checking anything at all.

Feb 27 2020, 2:45 AM · Restricted Project
jwakely added a comment to D75199: Build fix: Turn off _GLIBCXX_DEBUG on gcc 9.

I think this affects the versions of std::min(std::initializer_list) and std::max(std::initializer_list), and std::{min,max,minmax}_element. It's already fixed for GCC 10.

Feb 27 2020, 1:25 AM · Restricted Project

Sep 25 2019

jwakely resigned from D67944: Implement LWG 3296.

Note that MS-STL already has this behavior, while libstdc++ does not.

Sep 25 2019, 5:33 AM · Restricted Project

Aug 15 2019

jwakely added a comment to D66259: Migrate llvm::make_unique to std::make_unique.

FWIW I think this particular bug was https://gcc.gnu.org/PR65942

Aug 15 2019, 12:55 PM · Restricted Project
jwakely added a comment to D66259: Migrate llvm::make_unique to std::make_unique.

It looks like this breaks building with gcc5.1:

Aug 15 2019, 10:17 AM · Restricted Project

Jun 25 2019

jwakely added a comment to D51262: Implement P0553 and P0556.

I should also mention that as a conforming extension, I have implemented the non-numeric bit operations for std::byte

Jun 25 2019, 2:26 AM

Apr 24 2019

jwakely added a comment to D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

I added a patch to https://bugs.llvm.org/show_bug.cgi?id=41578 that fixes it differently.

Apr 24 2019, 5:42 AM

Feb 13 2019

jwakely added inline comments to D58201: Make std::memory_order an enum class (P0439R0).
Feb 13 2019, 4:15 PM · Restricted Project
jwakely added inline comments to D58201: Make std::memory_order an enum class (P0439R0).
Feb 13 2019, 3:07 PM · Restricted Project
jwakely added inline comments to D55840: P0722R3: Implement library support for destroying delete.
Feb 13 2019, 3:02 PM
jwakely added inline comments to D55840: P0722R3: Implement library support for destroying delete.
Feb 13 2019, 2:54 PM
jwakely added a comment to D55840: P0722R3: Implement library support for destroying delete.

TBH, I don't think that's a question the committee even thought about when introducing feature-test macros?

Feb 13 2019, 2:37 PM
jwakely added a comment to D55840: P0722R3: Implement library support for destroying delete.

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89345#c3 for what I've done in libstdc++

Feb 13 2019, 2:27 PM
jwakely added a comment to D55741: Implementation Feature Test Macros for P0722R3.

As it looks like libc++ isn't going to define the type for earlier dialects, libstdc++ doesn't either (which seems right anyway because the names aren't reserved prior to C++20).

Feb 13 2019, 2:18 PM · Restricted Project

Feb 7 2019

jwakely created D57887: [pstl] fix comment typos in test.
Feb 7 2019, 5:14 AM

Jan 23 2019

jwakely added a comment to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.

You are right, it is not guaranteed per the standard, although it has worked before (at least on MSVC).

Jan 23 2019, 7:04 AM
jwakely added inline comments to D56997: Fix implementation of P0966 - string::reserve Should Not Shrink.
Jan 23 2019, 7:02 AM

Jan 17 2019

jwakely added a comment to D55741: Implementation Feature Test Macros for P0722R3.

I'd be happy to restrict this to > C++17 only (which is automatically the case when using G++ because there's no -fdestroying-delete to enable it, you only get it with -std=c++2a, -std=gnu++2a etc.)

Jan 17 2019, 12:58 AM · Restricted Project

Jan 16 2019

jwakely added a comment to D55741: Implementation Feature Test Macros for P0722R3.

The simplest solution would be to change libstdc++'s <new> to:

Jan 16 2019, 4:02 PM · Restricted Project

May 9 2018

jwakely added a comment to D46593: Allow copy elision in path concatenation.

@chandlerc thanks for catching this.

May 9 2018, 4:28 PM

Jan 23 2017

jwakely added a comment to D28981: Use GNU-style attributes for several __throw_XXX() functions.

The __throw_xxx functions are not part of the public libstdc++ API and whatever Firefox is trying to do with them is not supported by libstdc++ and is undefined behaviour. Make it stop.

Jan 23 2017, 3:30 PM