Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Looks okay to me.
| lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp | ||
|---|---|---|
| 533 | int64_t? | |
| test/MC/AArch64/SVE/ld1sh-diagnostics.s | ||
| 150 | Nit: feel free to ignore this, but I think I would also test -1 and 63 simply because they are the first values out of range (I appreciate they are not a multiple of 2, for which there are checks.) Same comment about other files below. | |
| test/MC/AArch64/SVE/ld1sh-diagnostics.s | ||
|---|---|---|
| 150 | Fair point, I've added some more tests for these cases. | |
int64_t?