This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Asm: Support for gather LD1/LDFF1 (vector + imm) load instructions.
ClosedPublic

Authored by sdesmalen on Apr 26 2018, 7:42 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Apr 26 2018, 7:42 AM
SjoerdMeijer accepted this revision.Apr 27 2018, 2:15 AM

Looks okay to me.

lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
533 ↗(On Diff #144115)

int64_t?

test/MC/AArch64/SVE/ld1sh-diagnostics.s
150 ↗(On Diff #144115)

Nit: feel free to ignore this, but I think I would also test -1 and 63 simply because they are the first values out of range (I appreciate they are not a multiple of 2, for which there are checks.) Same comment about other files below.

This revision is now accepted and ready to land.Apr 27 2018, 2:15 AM
sdesmalen marked 2 inline comments as done.Apr 29 2018, 10:37 AM
sdesmalen added inline comments.
test/MC/AArch64/SVE/ld1sh-diagnostics.s
150 ↗(On Diff #144115)

Fair point, I've added some more tests for these cases.

This revision was automatically updated to reflect the committed changes.