This is an archive of the discontinued LLVM Phabricator instance.

Differential D45989

AMDGPU/R600: Move int_r600_store_stream_output to the public intrinsic file
ClosedPublic

Authored by tstellar on Apr 23 2018, 2:41 PM.

Details

Reviewers
jvesely
nhaehnle
Commits
rGdce46fa1cf10: AMDGPU/R600: Move int_r600_store_stream_output to the public intrinsic file
rL330866: AMDGPU/R600: Move int_r600_store_stream_output to the public intrinsic file
Summary

The TableGen'd GlobalISel instruction selector assumes all intrinsics are in
the public Intrinsic:: namespace.

Diff Detail

Event Timeline

tstellar created this revision.Apr 23 2018, 2:41 PM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptApr 23 2018, 2:41 PM
Harbormaster completed remote builds in B17346: Diff 143652.Apr 23 2018, 2:41 PM
nhaehnle accepted this revision.Apr 24 2018, 12:40 AM

Who is using this actually? Anyway, LGTM.

This revision is now accepted and ready to land.Apr 24 2018, 12:40 AM
tstellar added a comment.Apr 24 2018, 8:26 AM

I thought libclc was using this, but it is not. Maybe we can just delete this instead?

jvesely accepted this revision.Apr 24 2018, 4:29 PM
In D45989#1076813, @tstellar wrote:

I thought libclc was using this, but it is not. Maybe we can just delete this instead?

I think it was used by mesa GL llvm. Resurrecting it might be a pipe dream, but I'd prefer to keep it around for now.

Closed by commit rL330866: AMDGPU/R600: Move int_r600_store_stream_output to the public intrinsic file (authored by tstellar). · Explain WhyApr 25 2018, 1:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
IR/
4 lines
lib/
Target/
AMDGPU/
4 lines

Diff 143652

include/llvm/IR/IntrinsicsAMDGPU.td

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
def int_r600_recipsqrt_clamped : Intrinsic< def int_r600_recipsqrt_clamped : Intrinsic<
[llvm_anyfloat_ty], [LLVMMatchType<0>], [IntrNoMem, IntrSpeculatable] [llvm_anyfloat_ty], [LLVMMatchType<0>], [IntrNoMem, IntrSpeculatable]
>; >;
def int_r600_cube : Intrinsic< def int_r600_cube : Intrinsic<
[llvm_v4f32_ty], [llvm_v4f32_ty], [IntrNoMem, IntrSpeculatable] [llvm_v4f32_ty], [llvm_v4f32_ty], [IntrNoMem, IntrSpeculatable]
>; >;
def int_r600_store_stream_output : Intrinsic<
[], [llvm_v4f32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty], []
>;
} // End TargetPrefix = "r600" } // End TargetPrefix = "r600"
let TargetPrefix = "amdgcn" in { let TargetPrefix = "amdgcn" in {
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// ABI Special Intrinsics // ABI Special Intrinsics
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 1,240 Lines • Show Last 20 Lines

lib/Target/AMDGPU/R600Intrinsics.td

Show All 39 Lines
>; >;
let TargetPrefix = "r600", isTarget = 1 in { let TargetPrefix = "r600", isTarget = 1 in {
def int_r600_store_swizzle : def int_r600_store_swizzle :
Intrinsic<[], [llvm_v4f32_ty, llvm_i32_ty, llvm_i32_ty], [] Intrinsic<[], [llvm_v4f32_ty, llvm_i32_ty, llvm_i32_ty], []
>; >;
def int_r600_store_stream_output : Intrinsic<
[], [llvm_v4f32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty], []
>;
def int_r600_tex : TextureIntrinsicFloatInput; def int_r600_tex : TextureIntrinsicFloatInput;
def int_r600_texc : TextureIntrinsicFloatInput; def int_r600_texc : TextureIntrinsicFloatInput;
def int_r600_txl : TextureIntrinsicFloatInput; def int_r600_txl : TextureIntrinsicFloatInput;
def int_r600_txlc : TextureIntrinsicFloatInput; def int_r600_txlc : TextureIntrinsicFloatInput;
def int_r600_txb : TextureIntrinsicFloatInput; def int_r600_txb : TextureIntrinsicFloatInput;
def int_r600_txbc : TextureIntrinsicFloatInput; def int_r600_txbc : TextureIntrinsicFloatInput;
def int_r600_txf : TextureIntrinsicInt32Input; def int_r600_txf : TextureIntrinsicInt32Input;
def int_r600_txq : TextureIntrinsicInt32Input; def int_r600_txq : TextureIntrinsicInt32Input;
def int_r600_ddx : TextureIntrinsicFloatInput; def int_r600_ddx : TextureIntrinsicFloatInput;
def int_r600_ddy : TextureIntrinsicFloatInput; def int_r600_ddy : TextureIntrinsicFloatInput;
def int_r600_dot4 : Intrinsic<[llvm_float_ty], def int_r600_dot4 : Intrinsic<[llvm_float_ty],
[llvm_v4f32_ty, llvm_v4f32_ty], [IntrNoMem, IntrSpeculatable] [llvm_v4f32_ty, llvm_v4f32_ty], [IntrNoMem, IntrSpeculatable]
>; >;
} // End TargetPrefix = "r600", isTarget = 1 } // End TargetPrefix = "r600", isTarget = 1