This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/R600: Move int_r600_store_stream_output to the public intrinsic file
ClosedPublic

Authored by tstellar on Apr 23 2018, 2:41 PM.

Details

Summary

The TableGen'd GlobalISel instruction selector assumes all intrinsics are in
the public Intrinsic:: namespace.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellar created this revision.Apr 23 2018, 2:41 PM
nhaehnle accepted this revision.Apr 24 2018, 12:40 AM

Who is using this actually? Anyway, LGTM.

This revision is now accepted and ready to land.Apr 24 2018, 12:40 AM

I thought libclc was using this, but it is not. Maybe we can just delete this instead?

jvesely accepted this revision.Apr 24 2018, 4:29 PM

I thought libclc was using this, but it is not. Maybe we can just delete this instead?

I think it was used by mesa GL llvm. Resurrecting it might be a pipe dream, but I'd prefer to keep it around for now.

This revision was automatically updated to reflect the committed changes.