This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Fix filename in cross-file HTML report
ClosedPublic

Authored by malcolm.parsons on Apr 13 2018, 1:41 AM.

Details

Summary

The filename is currently taken from the start of the path, while the
line and column are taken from the end of the path.
This didn't matter until cross-file path reporting was added.

Diff Detail

Repository
rC Clang

Event Timeline

vlad.tsyrklevich accepted this revision.Apr 18 2018, 4:08 PM

This LGTM, but 1) you should add a test, probably just need to another CHECK to test/Coverage/html-multifile-diagnostics.c from D30406, and 2) someone from the analyzer team should sign off on it too.

This revision is now accepted and ready to land.Apr 18 2018, 4:08 PM
This revision was automatically updated to reflect the committed changes.
NoQ added a subscriber: NoQ.May 2 2018, 8:12 AM

Thanks! I noticed the problem but never investigated it.