Page MenuHomePhabricator

[CodeGen]Add NoVRegs property on PostRASink and ShrinkWrap
ClosedPublic

Authored by junbuml on Apr 2 2018, 1:33 PM.

Details

Summary

This change declare that PostRAMachineSinking and ShrinkWrap require NoVRegs
property, so now the MachineFunctionPass can enforce this check.
These passes are disabled in NVPTX & WebAssembly.

Diff Detail

Repository
rL LLVM

Event Timeline

junbuml created this revision.Apr 2 2018, 1:33 PM
dschuff accepted this revision.Apr 2 2018, 1:46 PM
This revision is now accepted and ready to land.Apr 2 2018, 1:46 PM

The shrink-wrap pass would already assert here. Could you add the property to ShrinkWrap as well?

The shrink-wrap pass would already assert here. Could you add the property to ShrinkWrap as well?

Sure. I will do this.

junbuml updated this revision to Diff 140807.Apr 3 2018, 8:58 AM
junbuml retitled this revision from [PostRASink] Add NoVRegs property to [CodeGen]Add NoVRegs property on PostRASink and ShrinkWrap.
junbuml edited the summary of this revision. (Show Details)

Added NoVRegs for ShrinkWrap as well.
Updated summary and title.

thegameg accepted this revision.EditedApr 3 2018, 9:52 AM

LGTM, Thank you!

This revision was automatically updated to reflect the committed changes.