This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Fixed unreachable with -print-machineinstrs and custom pseudo source value
ClosedPublic

Authored by tpr on Mar 24 2018, 10:41 AM.

Details

Summary

Rev 327580 "[CodeGen] Use MIR syntax for MachineMemOperand printing"
broke -print-machineinstrs for us on AMDGPU, because we have custom
pseudo source values, and MIR serialization does not implement that.

This commit at least restores the functionality of -print-machineinstrs,
even if it does not properly implement the missing MIR serialization
functionality.

Change-Id: I44961c0b90bf6d48c01484ed7a4e466fd300db66

Diff Detail

Repository
rL LLVM

Event Timeline

tpr created this revision.Mar 24 2018, 10:41 AM
tpr added subscribers: dstuttard, rtaylor.
thegameg accepted this revision.Mar 24 2018, 1:47 PM
thegameg added reviewers: MatzeB, qcolombet, bogner.

Thanks! I remember wanting to do this, I must have missed it, sorry.

It LGTM but it's missing a test case for -print-machineinstrs (no need for the whole thing, -print-before or -print-after should do it), so that we don't break this again in the future.

(adding some more reviewers which might be interested in this)

This revision is now accepted and ready to land.Mar 24 2018, 1:47 PM
nhaehnle accepted this revision.Mar 27 2018, 8:39 AM
This revision was automatically updated to reflect the committed changes.