This is an archive of the discontinued LLVM Phabricator instance.

Differential D44743

[clang-tidy] Marking hicpp-no-assembler-msvc unsupported on Windows
ClosedPublic

Authored by juliehockett on Mar 21 2018, 10:27 AM.

Details

Reviewers
zturner
phosek
JonasToth
aaron.ballman
alexfh
hokein
lebedev.ri
Summary

After changes to lit.site.cfg.in, the test is now running (and failing) on windows, so temporarily marking it unsupported. See PR36855 for more details.

Diff Detail

Event Timeline

juliehockett created this revision.Mar 21 2018, 10:27 AM
Herald added a subscriber: xazax.hun. · View Herald TranscriptMar 21 2018, 10:27 AM
lebedev.ri added a reviewer: JonasToth.Mar 21 2018, 10:29 AM
JonasToth added reviewers: aaron.ballman, alexfh, hokein.Mar 21 2018, 10:40 AM
phosek accepted this revision.Mar 21 2018, 10:40 AM

LGTM

This revision is now accepted and ready to land.Mar 21 2018, 10:40 AM
lebedev.ri accepted this revision.Mar 21 2018, 10:55 AM
juliehockett closed this revision.Mar 21 2018, 11:10 AM

Committed in r328127.

Revision Contents

PathSize
test/
clang-tidy/
2 lines

Diff 139319

test/clang-tidy/hicpp-no-assembler-msvc.cpp

// REQUIRES: system-windows // REQUIRES: system-windows
// FIXME: Re-enable test on windows (PR36855)
// UNSUPPORTED: system-windows
// RUN: %check_clang_tidy %s hicpp-no-assembler %t // RUN: %check_clang_tidy %s hicpp-no-assembler %t
void f() { void f() {
_asm { _asm {
mov al, 2; mov al, 2;
// CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in safety-critical code [hicpp-no-assembler] // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: do not use inline assembler in safety-critical code [hicpp-no-assembler]
} }
} }