Correct the alignment for the PS4 target

[ormris]

Summary

See above.

[cfe-commits]

LGTM.

• msg-22334-27.txt159 BDownload

[ormris]

Thanks! I’ll commit this.

From: Eric Christopher [mailto:[e-mail]]
Sent: Wednesday, March 7, 2018 12:33 PM
To: [e-mail]
Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail]; Voss, Matthew; [e-mail]
Subject: Re: [PATCH] D44218: Correct the alignment for the PS4 target

LGTM.

[ormris]

@echristo accepted this revision via cfe-commits. As it's now commited, I'm abandoning this revision.

lib/Basic/Targets/OSTargets.h

PS4OSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
     // On PS4, do not honor explicit bit field alignment,
     // as in "__attribute__((aligned(2))) int b : 1;".
     this->UseExplicitBitFieldAlignment = false;
 
     switch (Triple.getArch()) {
     default:
     case llvm::Triple::x86_64:
       this->MCountName = ".mcount";
+      this->NewAlign = 256;
       break;
     }
   }
 };
 
 // RTEMS Target
 template <typename Target>
 class LLVM_LIBRARY_VISIBILITY RTEMSTargetInfo : public OSTargetInfo<Target> {

test/Preprocessor/init.c

 // PS4:#define __amd64 1
 // PS4:#define __amd64__ 1
 // PS4:#define __unix 1
 // PS4:#define __unix__ 1
 // PS4:#define __x86_64 1
 // PS4:#define __x86_64__ 1
 // PS4:#define unix 1
 //
+// RUN: %clang_cc1 -x c++ -E -dM -ffreestanding -triple=x86_64-scei-ps4 < /dev/null | FileCheck -match-full-lines -check-prefix PS4-CXX %s
+// PS4-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 32UL
+//
 // RUN: %clang_cc1 -E -dM -triple=x86_64-pc-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s
 // RUN: %clang_cc1 -E -dM -fms-extensions -triple=x86_64-unknown-mingw32 < /dev/null | FileCheck -match-full-lines -check-prefix X86-64-DECLSPEC %s
 // X86-64-DECLSPEC: #define __declspec{{.*}}
 //
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=sparc64-none-none < /dev/null | FileCheck -match-full-lines -check-prefix SPARCV9 %s
 // SPARCV9:#define __INT64_TYPE__ long int
 // SPARCV9:#define __INTMAX_C_SUFFIX__ L
 // SPARCV9:#define __INTMAX_TYPE__ long int