This is an archive of the discontinued LLVM Phabricator instance.

Rename a few checks from misc- to bugprone-.
ClosedPublic

Authored by alexfh on Feb 28 2018, 4:39 AM.

Details

Summary

rename_check.py {misc,bugprone}-forwarding-reference-overload
rename_check.py {misc,bugprone}-macro-repeated-side-effects
rename_check.py {misc,bugprone}-lambda-function-name
rename_check.py {misc,bugprone}-misplaced-widening-cast

Diff Detail

Event Timeline

alexfh created this revision.Feb 28 2018, 4:39 AM
alexfh updated this revision to Diff 136275.Feb 28 2018, 4:42 AM
  • Fixed a header guard

When we do this sort of move, do we want to keep the check under its old name for a deprecation period so that we are less likely to break automated scripts and whatnot?

When we do this sort of move, do we want to keep the check under its old name for a deprecation period so that we are less likely to break automated scripts and whatnot?

I haven't done this for the previous ~15-20 moves. And I'm afraid this would be a rather significant complication of the whole process which I'm not sure how to automate. I hope, the release notes we provide should make the changes transparent enough for everyone who cares. Or do you have any evidence of these renames being actively harmful or at least significantly annoying?

aaron.ballman accepted this revision.Feb 28 2018, 5:13 AM

When we do this sort of move, do we want to keep the check under its old name for a deprecation period so that we are less likely to break automated scripts and whatnot?

I haven't done this for the previous ~15-20 moves. And I'm afraid this would be a rather significant complication of the whole process which I'm not sure how to automate. I hope, the release notes we provide should make the changes transparent enough for everyone who cares. Or do you have any evidence of these renames being actively harmful or at least significantly annoying?

If it's not been done before and people aren't filing bug reports about it, I'm certainly fine with continuing the status quo. I don't have direct evidence, just indirect evidence of flags being removed/renamed causing automated scripts to fail.

This LGTM, thank you!

This revision is now accepted and ready to land.Feb 28 2018, 5:13 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.