This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Tracing: name worker threads, and enforce naming scheduled async tasks
ClosedPublic

Authored by sammccall on Feb 16 2018, 7:44 AM.

Details

Summary

This has a bit of a blast radius, but I think there's enough value in "forcing"
us to give names to these async tasks for debugging. Guessing about what
multithreaded code is doing is so unfun...

The "file" param attached to the tasks may seem to be redundant with the thread
names, but note that thread names are truncated to 15 chars on linux!
We'll be lucky to get the whole basename...

Diff Detail

Event Timeline

sammccall created this revision.Feb 16 2018, 7:44 AM
ilya-biryukov accepted this revision.Feb 19 2018, 1:52 AM
This revision is now accepted and ready to land.Feb 19 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.