A followup to: https://reviews.llvm.org/D42978
This patch adds NVPTX support for
enabling the march notes.
Details
Diff Detail
Event Timeline
LGTM with an inline comment.
include/clang/Basic/Cuda.h | ||
---|---|---|
49 | We have last, invalid, etc... maybe we should pick one among all the targets? :) |
test/Misc/target-invalid-cpu-note.c | ||
---|---|---|
38 | Nit: Generally speaking this note is false. For any given version of CUDA, some of the listed GPU variants will not be accepted. E.g. CUDA versions before 9.1 do not know anything about sm_72, but CUDA-9.1 does not supports sm_20. |
test/Misc/target-invalid-cpu-note.c | ||
---|---|---|
38 | Is there somewhere else that this is checked? It seems that the 'setCPU' function here checks against this same list. |
test/Misc/target-invalid-cpu-note.c | ||
---|---|---|
38 | We have CheckCudaVersionSupportsArch() in lib/Driver/ToolChains/Cuda.cpp. I'm OK with the ful list for now if it's hard to get to the CUDA version. |
We have last, invalid, etc... maybe we should pick one among all the targets? :)