This is an archive of the discontinued LLVM Phabricator instance.

Add X86 Support to ValidCPUList (enabling march notes)
ClosedPublic

Authored by erichkeane on Feb 7 2018, 1:18 PM.

Diff Detail

Event Timeline

erichkeane created this revision.Feb 7 2018, 1:18 PM
erichkeane updated this revision to Diff 133443.Feb 8 2018, 9:46 AM

removed careless newline, also rebases off ARM patch.

This revision is now accepted and ready to land.Feb 8 2018, 10:26 AM
Hahnfeld added inline comments.
lib/Basic/Targets/X86.cpp
1670–1672

checkCPUKind() doesn't define PROC_ALIAS so I don't think it can handle the values?

test/Misc/target-invalid-cpu-note.c
12

If we really want to check all these values (does any other test do it? I don't really get the value) this line needs to be split, it's way too long.

Hahnfeld added inline comments.Feb 8 2018, 10:29 AM
lib/Basic/Targets/X86.cpp
1670–1672

Never mind, the enum value is enough. Silly me :-/

Cleaned up the test as suggested.

echristo accepted this revision.Feb 8 2018, 11:26 AM
This revision was automatically updated to reflect the committed changes.