This should also fix the current windows buildbot breakage
(http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/9838/steps/ninja%20check%201/logs/stdio)
Details
- Reviewers
sammccall - Commits
- rG5740ff5bed8a: [clangd] Add a test URI scheme for lit tests to unbreak platform-specific URI…
rL323885: [clangd] Add a test URI scheme for lit tests to unbreak platform-specific URI…
rCTE323885: [clangd] Add a test URI scheme for lit tests to unbreak platform-specific URI…
Diff Detail
- Repository
- rCTE Clang Tools Extra
- Build Status
Buildable 14465 Build 14465: arc lint + arc unit
Event Timeline
Thanks for fixing this once and for all!
clangd/ClangdLSPServer.cpp | ||
---|---|---|
23 | nit: URi -> URI | |
28 | nit: just inline this at the registry site? we shouldn't be using it elsewhere | |
47 | on windows you're passing C:\clangd-test and /foo.cpp here. | |
clangd/Protocol.cpp | ||
36 | I'd suggest not mentioning 'test' in the log message, and just making this a comment. |
nit: URi -> URI