This is an archive of the discontinued LLVM Phabricator instance.

Revert "Revert rC322769: [RISCV] Propagate -mabi and -march values to GNU assembler."
ClosedPublic

Authored by apazos on Jan 29 2018, 3:26 PM.

Diff Detail

Repository
rC Clang

Event Timeline

apazos created this revision.Jan 29 2018, 3:26 PM

I have tested this on windows and linux and the test passes on both. I simplified it further to avoid test failures.
Hiroshi, could you try this patch on your environment?
Yvan, can you also verify on your side?
I am not sure what other way I can test this to avoid a revert later.

inouehrs accepted this revision.Jan 30 2018, 11:16 PM

This time, the patch works on a ppc64le linux machine.
Thanks!

This revision is now accepted and ready to land.Jan 30 2018, 11:16 PM
yroux accepted this revision.Jan 31 2018, 5:43 AM

Tested on ARM boxes with success.
Patch LGTM

Thanks

Thank you both for testing.

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.